[installer] Remove default workspace template

Author: csweichel

components/installer/pkg/components/ws-manager/configmap.go

@@ -10,7 +10,6 @@ import (
 	"time"
 
 	wsdaemon "github.com/gitpod-io/gitpod/installer/pkg/components/ws-daemon"
-	"k8s.io/utils/pointer"
 	"sigs.k8s.io/yaml"
 
 	"github.com/gitpod-io/gitpod/common-go/grpc"
@@ -159,19 +158,6 @@ func buildWorkspaceTemplates(ctx *common.RenderContext) (config.WorkspacePodTemp
 		cfgTpls = &configv1.WorkspaceTemplates{}
 	}
 
-	cfgTpls.Default = &corev1.Pod{
-		Spec: corev1.PodSpec{
-			EnableServiceLinks: pointer.Bool(false),
-			DNSConfig: &corev1.PodDNSConfig{
-				Nameservers: []string{
-					"1.1.1.1",
-					"8.8.8.8",
-				},
-			},
-			DNSPolicy: corev1.DNSNone,
-		},
-	}
-
 	ops := []struct {
 		Name string
 		Path *string

components/installer/pkg/components/ws-manager/configmap_test.go

@@ -29,19 +29,13 @@ func TestBuildWorkspaceTemplates(t *testing.T) {
 		Expectation       Expectation
 	}{
 		{
-			Name: "no templates",
-			Expectation: Expectation{
-				TplConfig: wsmancfg.WorkspacePodTemplateConfiguration{DefaultPath: "/workspace-templates/default.yaml"},
-				Data:      map[string]bool{"default.yaml": true},
-			},
+			Name:        "no templates",
+			Expectation: Expectation{},
 		},
 		{
-			Name:   "empty templates",
-			Config: &configv1.WorkspaceTemplates{},
-			Expectation: Expectation{
-				TplConfig: wsmancfg.WorkspacePodTemplateConfiguration{DefaultPath: "/workspace-templates/default.yaml"},
-				Data:      map[string]bool{"default.yaml": true},
-			},
+			Name:        "empty templates",
+			Config:      &configv1.WorkspaceTemplates{},
+			Expectation: Expectation{},
 		},
 		{
 			Name: "default tpl",
@@ -60,11 +54,9 @@ func TestBuildWorkspaceTemplates(t *testing.T) {
 			},
 			Expectation: Expectation{
 				TplConfig: wsmancfg.WorkspacePodTemplateConfiguration{
-					DefaultPath: "/workspace-templates/default.yaml",
 					RegularPath: "/workspace-templates/regular.yaml",
 				},
 				Data: map[string]bool{
-					"default.yaml": true,
 					"regular.yaml": true,
 				},
 			},
@@ -76,11 +68,9 @@ func TestBuildWorkspaceTemplates(t *testing.T) {
 			},
 			Expectation: Expectation{
 				TplConfig: wsmancfg.WorkspacePodTemplateConfiguration{
-					DefaultPath:  "/workspace-templates/default.yaml",
 					PrebuildPath: "/workspace-templates/prebuild.yaml",
 				},
 				Data: map[string]bool{
-					"default.yaml":  true,
 					"prebuild.yaml": true,
 				},
 			},
@@ -92,12 +82,10 @@ func TestBuildWorkspaceTemplates(t *testing.T) {
 			},
 			Expectation: Expectation{
 				TplConfig: wsmancfg.WorkspacePodTemplateConfiguration{
-					DefaultPath: "/workspace-templates/default.yaml",
-					GhostPath:   "/workspace-templates/ghost.yaml",
+					GhostPath: "/workspace-templates/ghost.yaml",
 				},
 				Data: map[string]bool{
-					"default.yaml": true,
-					"ghost.yaml":   true,
+					"ghost.yaml": true,
 				},
 			},
 		},
@@ -108,11 +96,9 @@ func TestBuildWorkspaceTemplates(t *testing.T) {
 			},
 			Expectation: Expectation{
 				TplConfig: wsmancfg.WorkspacePodTemplateConfiguration{
-					DefaultPath:    "/workspace-templates/default.yaml",
 					ImagebuildPath: "/workspace-templates/imagebuild.yaml",
 				},
 				Data: map[string]bool{
-					"default.yaml":    true,
 					"imagebuild.yaml": true,
 				},
 			},