[chart] Set EnableServiceLinks=false

Author: aledbf

chart/templates/blobserve-deployment.yaml

@@ -45,6 +45,7 @@ spec:
     spec:
 {{ include "gitpod.workspaceAffinity" $this | indent 6 }}
       serviceAccountName: blobserve
+      enableServiceLinks: false
       containers:
       - name: blobserve
         image: {{ template "gitpod.comp.imageFull" $this }}

chart/templates/cerc-deployment.yaml

@@ -38,6 +38,7 @@ spec:
       serviceAccountName: cerc
       securityContext:
         runAsUser: 1000
+      enableServiceLinks: false
       containers:
       - name: cerc
         image: {{ template "gitpod.comp.imageFull" $this }}

chart/templates/content-service-deployment.yaml

@@ -44,6 +44,7 @@ spec:
     spec:
 {{ include "gitpod.pod.affinity" $this | indent 6 }}
       serviceAccountName: content-service
+      enableServiceLinks: false
       containers:
       - name: content-service
         image: {{ template "gitpod.comp.imageFull" $this }}

chart/templates/dashboard-deployment.yaml

@@ -39,6 +39,7 @@ spec:
     spec:
 {{ include "gitpod.pod.affinity" $this | indent 6 }}
       serviceAccountName: dashboard
+      enableServiceLinks: false
       containers:
       - name: dashboard
         image: {{ template "gitpod.comp.imageFull" $this }}

chart/templates/db-deployment.yaml

@@ -37,6 +37,7 @@ spec:
     spec:
 {{ include "gitpod.pod.affinity" $this | indent 6 }}
       serviceAccountName: db
+      enableServiceLinks: false
       containers:
       - name: cloud-sql-proxy
         securityContext:

chart/templates/db-migrations-job.yaml

@@ -38,6 +38,7 @@ spec:
 {{- range $key, $value := .Values.defaults.imagePullSecrets }}
       - name: {{ $value.name }}
 {{- end }}
+      enableServiceLinks: false
       containers:
       - name: db-migrations
         image: "{{ template "gitpod.comp.imageFull" (dict "root" . "gp" .Values "comp" $.Values.components.dbMigrations) }}"

chart/templates/image-builder-deployment.yaml

@@ -64,6 +64,7 @@ spec:
         secret:
           secretName: {{ $sec.secret }}
 {{- end }}
+      enableServiceLinks: false
       containers:
       - name: dind
         image: {{ $comp.dindImage | default "docker:19.03-dind" }}

chart/templates/proxy-deployment.yaml

@@ -74,6 +74,7 @@ spec:
       serviceAccount: proxy
       securityContext:
         runAsNonRoot: false
+      enableServiceLinks: false
       initContainers:
         - name: "sysctl"
           image: "alpine:3.13"

chart/templates/registry-facade-daemonset.yaml

@@ -38,6 +38,7 @@ spec:
     spec:
 {{ include "gitpod.workspaceAffinity" $this | indent 6 }}
       serviceAccountName: registry-facade
+      enableServiceLinks: false
 {{- if $comp.handover.enabled }}
       initContainers:
       - name: handover-ownership

chart/templates/restarter-cronjob.yaml

@@ -21,6 +21,7 @@ spec:
     spec:
       template:
         spec:
+          enableServiceLinks: false
           containers:
           - name: kubectl
             image: {{ .Values.components.restarter.image }}

chart/templates/server-deployment.yaml

@@ -83,6 +83,7 @@ spec:
     spec:
 {{ include "gitpod.pod.affinity" $this | indent 6 }}
       serviceAccountName: server
+      enableServiceLinks: false
       initContainers:
 {{ include "gitpod.msgbusWaiter.container" $this | indent 6 }}
 {{ include "gitpod.databaseWaiter.container" $this | indent 6 }}

chart/templates/ws-daemon-daemonset.yaml

@@ -105,6 +105,7 @@ spec:
 {{- if $comp.volumes }}
 {{ toYaml $comp.volumes | indent 6 }}
 {{- end }}
+      enableServiceLinks: false
 {{- if (or $comp.userNamespaces.shiftfsModuleLoader.enabled $comp.userNamespaces.seccompProfileInstaller.enabled) }}
       initContainers:
 {{- end }}

chart/templates/ws-manager-bridge-deployment.yaml

@@ -41,6 +41,7 @@ spec:
     spec:
 {{ include "gitpod.pod.affinity" $this | indent 6 }}
       serviceAccountName: ws-manager-bridge
+      enableServiceLinks: false
       initContainers:
 {{ include "gitpod.databaseWaiter.container" $this | indent 6 }}
 {{ include "gitpod.msgbusWaiter.container" $this | indent 6 }}

chart/templates/ws-manager-deployment.yaml

@@ -60,6 +60,7 @@ spec:
 {{- if $comp.volumes }}
 {{ toYaml $comp.volumes | indent 6 }}
 {{- end }}
+      enableServiceLinks: false
       containers:
       - name: ws-manager
         args: ["run", "-v", "--config", "/config/config.json"]

chart/templates/ws-proxy-deployment.yaml

@@ -55,6 +55,7 @@ spec:
         secret:
           secretName: {{ $.Values.certificatesSecret.secretName }}
 {{- end }}
+      enableServiceLinks: false
       containers:
       - name: ws-proxy
         image: {{ template "gitpod.comp.imageFull" $this }}

chart/templates/ws-scheduler-deployment.yaml

@@ -50,6 +50,7 @@ spec:
       - name: ws-manager-client-tls-certs
         secret:
           secretName: {{ .Values.components.wsManager.tls.client.secretName }}
+      enableServiceLinks: false
       containers:
       - name: scheduler
         args: ["run", "-v", "--config", "/config/config.json"]

chart/values.yaml

@@ -312,6 +312,7 @@ components:
     template:
       default:
         spec:
+            enableServiceLinks: false
             dnsConfig:
             nameservers:
             - 1.1.1.1

dev/charts/jaeger/templates/jaeger-deployment.yaml

@@ -29,6 +29,7 @@ spec:
       serviceAccountName: monitoring-jaeger
       securityContext:
         runAsUser: 1000
+      enableServiceLinks: false
       containers:
       - image: jaegertracing/all-in-one:1.14
         imagePullPolicy: Always

dev/charts/poolkeeper/templates/deployment.yaml

@@ -21,6 +21,7 @@ spec:
       serviceAccountName: {{ include "poolkeeper.serviceAccountName" . }}
       securityContext:
         {{- toYaml .Values.podSecurityContext | nindent 8 }}
+      enableServiceLinks: false
       containers:
         - name: {{ .Chart.Name }}
           securityContext:

dev/charts/sweeper/templates/deployment.yaml

@@ -21,6 +21,7 @@ spec:
       serviceAccountName: {{ .Values.serviceAccountName }}
       securityContext:
         {{- toYaml .Values.podSecurityContext | nindent 8 }}
+      enableServiceLinks: false
       containers:
         - name: {{ .Chart.Name }}
           securityContext: