[registry-facade] Add additional GetBlob error logs

Author: aledbf

components/registry-facade/pkg/registry/blob.go

@@ -172,12 +172,13 @@ func (bh *blobHandler) getBlob(w http.ResponseWriter, r *http.Request) {
 
 		n, err := io.CopyBuffer(w, rc, *bp)
 		if err != nil {
-			log.WithError(err).Error("unable to return blob")
+			bh.Metrics.BlobDownloadCounter.WithLabelValues(src.Name(), "false").Inc()
+			log.WithField("blobSource", src.Name()).WithField("baseRef", bh.Spec.BaseRef).WithError(err).Error("unable to return blob")
 			return err
 		}
 
 		bh.Metrics.BlobDownloadSpeedHist.WithLabelValues(src.Name()).Observe(float64(n) / time.Since(t0).Seconds())
-		bh.Metrics.BlobDownloadCounter.WithLabelValues(src.Name()).Inc()
+		bh.Metrics.BlobDownloadCounter.WithLabelValues(src.Name(), "true").Inc()
 		bh.Metrics.BlobDownloadSizeCounter.WithLabelValues(src.Name()).Add(float64(n))
 
 		if dontCache {

components/registry-facade/pkg/registry/metrics.go

@@ -93,7 +93,7 @@ func newMetrics(reg prometheus.Registerer, upstream bool) (*metrics, error) {
 	blobDownloadCounter := prometheus.NewCounterVec(prometheus.CounterOpts{
 		Name: "blob_req_dl_total",
 		Help: "number of blob download requests",
-	}, []string{"blobSource"})
+	}, []string{"blobSource", "ok"})
 	err = reg.Register(blobDownloadCounter)
 	if err != nil {
 		return nil, err