Redirect when not owner

Author: Laurie T. Malau

components/dashboard/src/Menu.tsx

@@ -108,8 +108,8 @@ export default function Menu() {
             ];
         }
         // Team menu
-        if (team) {
-            const currentUserInTeam = teamMembers[team.id];
+        if (team && teamMembers && teamMembers[team.id]) {
+            const currentUserInTeam = teamMembers[team.id].find(m => m.userId === user?.id);
 
             const teamSettingsList = [
                 {
@@ -126,7 +126,7 @@ export default function Menu() {
                     link: `/t/${team.slug}/members`
                 }
             ];
-            if (currentUserInTeam && currentUserInTeam[0].role === "owner") {
+            if (currentUserInTeam?.role === "owner") {
                 teamSettingsList.push({
                     title: 'Settings',
                     link: `/t/${team.slug}/settings`,

components/dashboard/src/teams/TeamSettings.tsx

@@ -5,7 +5,7 @@
  */
 
 import { useContext, useState } from "react";
-import { useLocation } from "react-router";
+import { Redirect, useLocation } from "react-router";
 import ConfirmationModal from "../components/ConfirmationModal";
 import { PageWithSubMenu } from "../components/PageWithSubMenu";
 import { getGitpodService, gitpodHostUrl } from "../service/service";
@@ -37,6 +37,18 @@ export default function TeamSettings() {
         }
     ]
 
+    const userIsOwner = async () => {
+        if (!team) return;
+
+        const members = await getGitpodService().server.getTeamMembers(team.id);
+        const currentUserInTeam = members.find(member => member.userId === user?.id);
+        return currentUserInTeam?.role === 'owner';
+    }
+
+    if (!userIsOwner) {
+        return <Redirect to="/"/>
+    }
+
     return <>
         <PageWithSubMenu subMenu={settingsMenu} title='General' subtitle='Manage general team settings.'>
             <h3>Delete Team</h3>