Skip to content

Commit 9e8b89e

Browse files
jentingroboquat
authored andcommitted
image-builder-mk3: log JSON as an object instead of a string
Signed-off-by: JenTing Hsiao <[email protected]>
1 parent b0c039f commit 9e8b89e

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

components/image-builder-mk3/pkg/orchestrator/orchestrator.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,9 @@ func (o *Orchestrator) ResolveBaseImage(ctx context.Context, req *protocol.Resol
151151

152152
reqs, _ := protojson.Marshal(req)
153153
safeReqs, _ := log.RedactJSON(reqs)
154-
log.WithField("req", string(safeReqs)).Debug("ResolveBaseImage")
154+
safeReqsLog := make(map[string]interface{})
155+
_ = json.Unmarshal(safeReqs, &safeReqsLog)
156+
log.WithFields(safeReqsLog).Debug("ResolveBaseImage")
155157

156158
reqauth := o.AuthResolver.ResolveRequestAuth(req.Auth)
157159

@@ -173,7 +175,9 @@ func (o *Orchestrator) ResolveWorkspaceImage(ctx context.Context, req *protocol.
173175

174176
reqs, _ := protojson.Marshal(req)
175177
safeReqs, _ := log.RedactJSON(reqs)
176-
log.WithField("req", string(safeReqs)).Debug("ResolveWorkspaceImage")
178+
safeReqsLog := make(map[string]interface{})
179+
_ = json.Unmarshal(safeReqs, &safeReqsLog)
180+
log.WithFields(safeReqsLog).Debug("ResolveWorkspaceImage")
177181

178182
reqauth := o.AuthResolver.ResolveRequestAuth(req.Auth)
179183
baseref, err := o.getBaseImageRef(ctx, req.Source, reqauth)

0 commit comments

Comments
 (0)