Skip to content

Commit ba261d7

Browse files
Andrew Farriesroboquat
Andrew Farries
authored andcommitted
Add test for server deployment tracing config
Check that the server deployment uses tracing values defined in `expermental.webapp.tracing`.
1 parent 43d98b3 commit ba261d7

File tree

1 file changed

+37
-0
lines changed

1 file changed

+37
-0
lines changed

install/installer/pkg/components/server/render_test.go

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,50 @@ func TestServerDeployment_MountsGithubAppSecret(t *testing.T) {
4545
require.Truef(t, foundMount, "failed to find expected volume mount %q on server container", githubAppCertSecret)
4646
}
4747

48+
func TestServerDeployment_UsesTracingConfig(t *testing.T) {
49+
ctx := renderContext(t)
50+
51+
objects, err := deployment(ctx)
52+
require.NoError(t, err)
53+
54+
require.Len(t, objects, 1, "must render only one object")
55+
56+
deployment := objects[0].(*appsv1.Deployment)
57+
58+
serverContainer := deployment.Spec.Template.Spec.Containers[0]
59+
60+
var envVars = make(map[string]string, len(serverContainer.Env))
61+
for _, envVar := range serverContainer.Env {
62+
envVars[envVar.Name] = envVar.Value
63+
}
64+
65+
actualSamplerType := envVars["JAEGER_SAMPLER_TYPE"]
66+
actualSamplerParam := envVars["JAEGER_SAMPLER_PARAM"]
67+
68+
require.Equal(t, "probabilistic", actualSamplerType)
69+
require.Equal(t, "12.5", actualSamplerParam)
70+
}
71+
4872
func renderContext(t *testing.T) *common.RenderContext {
73+
var samplerType experimental.TracingSampleType = "probabilistic"
74+
4975
ctx, err := common.NewRenderContext(config.Config{
5076
Database: config.Database{
5177
InCluster: pointer.Bool(true),
5278
},
79+
Observability: config.Observability{
80+
LogLevel: config.LogLevelInfo,
81+
Tracing: &config.Tracing{
82+
Endpoint: pointer.String("some-endpoint"),
83+
AgentHost: pointer.String("some-agent-host"),
84+
},
85+
},
5386
Experimental: &experimental.Config{
5487
WebApp: &experimental.WebAppConfig{
88+
Tracing: &experimental.Tracing{
89+
SamplerType: &samplerType,
90+
SamplerParam: pointer.Float64(12.5),
91+
},
5592
Server: &experimental.ServerConfig{
5693
GithubApp: &experimental.GithubApp{
5794
AppId: 0,

0 commit comments

Comments
 (0)