Skip to content

Commit c4b43f3

Browse files
committed
[public-api] Rename HTTP port to Debug
1 parent de164f8 commit c4b43f3

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

install/installer/pkg/components/public-api-server/constants.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ package public_api_server
77
const (
88
Component = "public-api-server"
99

10-
HTTPPortName = "http"
11-
HTTPContainerPort = 9000
12-
HTTPServicePort = 9000
10+
DebugPortName = "debug"
11+
DebugContainerPort = 9000
12+
DebugServicePort = 9000
1313

1414
GRPCPortName = "grpc"
1515
GRPCContainerPort = 9001

install/installer/pkg/components/public-api-server/deployment.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) {
4747
Name: Component,
4848
Image: ctx.ImageName(ctx.Config.Repository, Component, ctx.VersionManifest.Components.PublicAPIServer.Version),
4949
Args: []string{
50-
fmt.Sprintf("--http-port=%d", HTTPContainerPort),
50+
fmt.Sprintf("--debug-port=%d", DebugContainerPort),
5151
fmt.Sprintf("--grpc-port=%d", GRPCContainerPort),
5252
fmt.Sprintf("--gitpod-api-url=wss://%s/api/v1", ctx.Config.Domain),
5353
},
@@ -60,8 +60,8 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) {
6060
}),
6161
Ports: []corev1.ContainerPort{
6262
{
63-
ContainerPort: HTTPContainerPort,
64-
Name: HTTPPortName,
63+
ContainerPort: DebugContainerPort,
64+
Name: DebugPortName,
6565
},
6666
{
6767
ContainerPort: GRPCContainerPort,
@@ -78,7 +78,7 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) {
7878
ProbeHandler: corev1.ProbeHandler{
7979
HTTPGet: &corev1.HTTPGetAction{
8080
Path: "/live",
81-
Port: intstr.IntOrString{IntVal: HTTPContainerPort},
81+
Port: intstr.IntOrString{IntVal: DebugContainerPort},
8282
Scheme: corev1.URISchemeHTTP,
8383
},
8484
},
@@ -90,7 +90,7 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) {
9090
ProbeHandler: corev1.ProbeHandler{
9191
HTTPGet: &corev1.HTTPGetAction{
9292
Path: "/ready",
93-
Port: intstr.IntOrString{IntVal: HTTPContainerPort},
93+
Port: intstr.IntOrString{IntVal: DebugContainerPort},
9494
Scheme: corev1.URISchemeHTTP,
9595
},
9696
},
@@ -99,7 +99,7 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) {
9999
TimeoutSeconds: 1,
100100
},
101101
},
102-
*common.KubeRBACProxyContainerWithConfig(ctx, 9500, fmt.Sprintf("http://127.0.0.1:%d/", HTTPContainerPort)),
102+
*common.KubeRBACProxyContainerWithConfig(ctx, 9500, fmt.Sprintf("http://127.0.0.1:%d/", DebugContainerPort)),
103103
},
104104
},
105105
},

install/installer/pkg/components/public-api-server/networkpolicy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ func networkpolicy(ctx *common.RenderContext) ([]runtime.Object, error) {
3131
Ports: []networkingv1.NetworkPolicyPort{
3232
{
3333
Protocol: common.TCPProtocol,
34-
Port: &intstr.IntOrString{IntVal: HTTPContainerPort},
34+
Port: &intstr.IntOrString{IntVal: DebugContainerPort},
3535
},
3636
{
3737
Protocol: common.TCPProtocol,

install/installer/pkg/components/public-api-server/networkpolicy_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func TestNetworkPolicy(t *testing.T) {
2727
Ports: []networkingv1.NetworkPolicyPort{
2828
{
2929
Protocol: common.TCPProtocol,
30-
Port: &intstr.IntOrString{IntVal: HTTPContainerPort},
30+
Port: &intstr.IntOrString{IntVal: DebugContainerPort},
3131
},
3232
{
3333
Protocol: common.TCPProtocol,

install/installer/pkg/components/public-api-server/service.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ import (
1010

1111
func service(ctx *common.RenderContext) ([]runtime.Object, error) {
1212
return common.GenerateService(Component, map[string]common.ServicePort{
13-
HTTPPortName: {
14-
ContainerPort: HTTPContainerPort,
15-
ServicePort: HTTPServicePort,
13+
DebugPortName: {
14+
ContainerPort: DebugContainerPort,
15+
ServicePort: DebugServicePort,
1616
},
1717
GRPCPortName: {
1818
ContainerPort: GRPCContainerPort,

0 commit comments

Comments
 (0)