Skip to content

Commit ca37fdb

Browse files
jentingroboquat
authored andcommitted
Revert "Add annotation gitpod.io/startedDisposal once we enter finalize workspace content"
This reverts commit e40e43d. Signed-off-by: JenTing Hsiao <[email protected]>
1 parent f6af776 commit ca37fdb

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

components/ws-manager/pkg/manager/monitor.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -984,12 +984,6 @@ func (m *Monitor) finalizeWorkspaceContent(ctx context.Context, wso *workspaceOb
984984
return
985985
}
986986

987-
err := m.manager.markWorkspace(ctx, workspaceID, addMark(startedDisposalAnnotation, util.BooleanTrueString))
988-
if err != nil {
989-
tracing.LogError(span, err)
990-
log.WithError(err).Error("was unable to update pod's start disposal state - this might cause an incorrect disposal state")
991-
}
992-
993987
var disposalStatus *workspaceDisposalStatus
994988
defer func() {
995989
if disposalStatus == nil {
@@ -1096,6 +1090,12 @@ func (m *Monitor) finalizeWorkspaceContent(ctx context.Context, wso *workspaceOb
10961090
cancelReq()
10971091
}()
10981092

1093+
err = m.manager.markWorkspace(ctx, workspaceID, addMark(startedDisposalAnnotation, util.BooleanTrueString))
1094+
if err != nil {
1095+
tracing.LogError(span, err)
1096+
log.WithError(err).Error("was unable to update pod's start disposal state - this might cause an incorrect disposal state")
1097+
}
1098+
10991099
if pvcFeatureEnabled {
11001100
// pvc was created with the name of the pod. see createDefiniteWorkspacePod()
11011101
pvcName := wso.Pod.Name

0 commit comments

Comments
 (0)