Skip to content

Commit cad4fbf

Browse files
aledbfroboquat
authored andcommitted
[ws-manmager] Remove span logs from WorkspaceReadyProbe
1 parent 4543a07 commit cad4fbf

File tree

1 file changed

+0
-4
lines changed
  • components/ws-manager/pkg/manager

1 file changed

+0
-4
lines changed

components/ws-manager/pkg/manager/probe.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,25 +78,21 @@ func (p *WorkspaceReadyProbe) Run(ctx context.Context) WorkspaceProbeResult {
7878
return WorkspaceProbeStopped
7979
}
8080

81-
span.LogKV("event", "probe start")
8281
resp, err := client.Get(p.readyURL)
8382
if err != nil {
8483
urlerr, ok := err.(*url.Error)
8584
if !ok || !urlerr.Timeout() {
86-
span.LogKV("response", "error")
8785
log.WithError(err).Debug("got a non-timeout error during workspace probe")
8886
time.Sleep(p.RetryDelay)
8987
continue
9088
}
9189

9290
// we've timed out - do not log this as it would spam the logs for no good reason
93-
span.LogKV("response", "timeout")
9491
continue
9592
}
9693
resp.Body.Close()
9794

9895
if resp.StatusCode != http.StatusOK {
99-
span.LogKV("response", resp.StatusCode)
10096
log.WithField("url", p.readyURL).WithField("status", resp.StatusCode).Debug("workspace did not respond to ready probe with OK status")
10197
time.Sleep(p.RetryDelay)
10298
continue

0 commit comments

Comments
 (0)