Skip to content

Commit d43b464

Browse files
easyCZroboquat
authored andcommitted
Document ClusterService rpcs and messages
1 parent 76cba59 commit d43b464

File tree

4 files changed

+33
-6
lines changed

4 files changed

+33
-6
lines changed

components/ws-manager-bridge-api/cluster-service.proto

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,18 @@ package workspacemanagerbridge;
88

99
option go_package = "github.com/gitpod-io/gitpod/workspace-manager-bridge/api";
1010

11+
// ClusterService enables WorkspaceClusters to be dynamically managed.
1112
service ClusterService {
13+
// Register registers a new WorkspaceCluster.
1214
rpc Register(RegisterRequest) returns (RegisterResponse) {}
15+
16+
// Update modififes properties of an already registered WorkspaceCluster.
1317
rpc Update(UpdateRequest) returns (UpdateResponse) {}
18+
19+
// Deregister removes a WorkspaceCluster from available clusters.
1420
rpc Deregister(DeregisterRequest) returns (DeregisterResponse) {}
21+
22+
// List returns the currently registered WorkspaceClusters.
1523
rpc List(ListRequest) returns (ListResponse) {}
1624
}
1725

@@ -104,7 +112,10 @@ message ModifyAdmissionConstraint {
104112
message UpdateResponse {}
105113

106114
message DeregisterRequest {
115+
// name is the name of the WorkspaceCluster to deregister
107116
string name = 1;
117+
// force causes the cluster to be deregistered even if there are
118+
// intances still running on the cluster.
108119
bool force = 2;
109120
}
110121

components/ws-manager-bridge-api/go/cluster-service.pb.go

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

components/ws-manager-bridge-api/go/cluster-service_grpc.pb.go

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

components/ws-manager-bridge-api/typescript/src/cluster-service_grpc_pb.js

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,10 @@ function deserialize_workspacemanagerbridge_UpdateResponse(buffer_arg) {
9898
}
9999

100100

101+
// ClusterService enables WorkspaceClusters to be dynamically managed.
101102
var ClusterServiceService = exports.ClusterServiceService = {
102-
register: {
103+
// Register registers a new WorkspaceCluster.
104+
register: {
103105
path: '/workspacemanagerbridge.ClusterService/Register',
104106
requestStream: false,
105107
responseStream: false,
@@ -110,7 +112,8 @@ var ClusterServiceService = exports.ClusterServiceService = {
110112
responseSerialize: serialize_workspacemanagerbridge_RegisterResponse,
111113
responseDeserialize: deserialize_workspacemanagerbridge_RegisterResponse,
112114
},
113-
update: {
115+
// Update modififes properties of an already registered WorkspaceCluster.
116+
update: {
114117
path: '/workspacemanagerbridge.ClusterService/Update',
115118
requestStream: false,
116119
responseStream: false,
@@ -121,7 +124,8 @@ var ClusterServiceService = exports.ClusterServiceService = {
121124
responseSerialize: serialize_workspacemanagerbridge_UpdateResponse,
122125
responseDeserialize: deserialize_workspacemanagerbridge_UpdateResponse,
123126
},
124-
deregister: {
127+
// Deregister removes a WorkspaceCluster from available clusters.
128+
deregister: {
125129
path: '/workspacemanagerbridge.ClusterService/Deregister',
126130
requestStream: false,
127131
responseStream: false,
@@ -132,7 +136,8 @@ var ClusterServiceService = exports.ClusterServiceService = {
132136
responseSerialize: serialize_workspacemanagerbridge_DeregisterResponse,
133137
responseDeserialize: deserialize_workspacemanagerbridge_DeregisterResponse,
134138
},
135-
list: {
139+
// List returns the currently registered WorkspaceClusters.
140+
list: {
136141
path: '/workspacemanagerbridge.ClusterService/List',
137142
requestStream: false,
138143
responseStream: false,

0 commit comments

Comments
 (0)