[dashboard] Apply code review suggestions

jankeromnes · svenefftinge · commit eda11c29c38a · 2021-03-15T07:56:45.000Z
diff --git a/components/dashboard/src/App.tsx b/components/dashboard/src/App.tsx
@@ -48,11 +48,12 @@ function App() {
         window.location.reload(true);
       }
     }, false);
-    const hash = window.location.hash.replace(/^[#/]+/, '');
+
+    const hash = getURLHash();
     if (window.location.pathname === '/' && hash !== '') {
       return <CreateWorkspace contextUrl={hash} gitpodService={gitpodService}/>;
     }
-    if (/\/start\/?/.test(window.location.pathname)) {
+    if (/\/start\/?/.test(window.location.pathname) && hash !== '') {
       return <StartWorkspace workspaceId={hash} gitpodService={gitpodService}/>;
     }
 
@@ -85,6 +86,10 @@ function App() {
     );
 }
 
+function getURLHash () {
+  return window.location.hash.replace(/^[#/]+/, '');
+}
+
 const renderMenu = () => (
     <Menu left={[
         {

Original file line number	Diff line number	Diff line change
`@@ -48,11 +48,12 @@ function App() {`
`48`	`48`	`window.location.reload(true);`
`49`	`49`	`}`
`50`	`50`	`}, false);`
`51`		`- const hash = window.location.hash.replace(/^[#/]+/, '');`
	`51`	`+`
	`52`	`+ const hash = getURLHash();`
`52`	`53`	`if (window.location.pathname === '/' && hash !== '') {`
`53`	`54`	`return <CreateWorkspace contextUrl={hash} gitpodService={gitpodService}/>;`
`54`	`55`	`}`
`55`		`- if (/\/start\/?/.test(window.location.pathname)) {`
	`56`	`+ if (/\/start\/?/.test(window.location.pathname) && hash !== '') {`
`56`	`57`	`return <StartWorkspace workspaceId={hash} gitpodService={gitpodService}/>;`
`57`	`58`	`}`
`58`	`59`
`@@ -85,6 +86,10 @@ function App() {`
`85`	`86`	`);`
`86`	`87`	`}`
`87`	`88`
	`89`	`+function getURLHash () {`
	`90`	`+ return window.location.hash.replace(/^[#/]+/, '');`
	`91`	`+}`
	`92`	`+`
`88`	`93`	`const renderMenu = () => (`
`89`	`94`	`<Menu left={[`
`90`	`95`	`{`