Skip to content

Commit fa32177

Browse files
committed
Update prebuild and incremental prebuild emojis
1 parent f05f5bd commit fa32177

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

components/supervisor/pkg/supervisor/tasks.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -498,14 +498,14 @@ func (tm *tasksManager) watch(task *task, term *terminal.Term) {
498498
duration := ""
499499
if elapsed >= 1*time.Minute {
500500
elapsedInMinutes := strconv.Itoa(int(math.Round(elapsed.Minutes())))
501-
duration = "⏱️ Well done on saving " + elapsedInMinutes + " minute"
501+
duration = "⏱️\bWell done on saving " + elapsedInMinutes + " minute"
502502
if elapsedInMinutes != "1" {
503503
duration += "s"
504504
}
505505
duration += "\r\n"
506506
}
507507

508-
endMessage := "\r\n🍊 This task ran as a workspace prebuild\r\n" + duration + "\r\n"
508+
endMessage := "\r\n\bThis task ran as a workspace prebuild\r\n" + duration + "\r\n"
509509
_, _ = writer.Write([]byte(endMessage))
510510

511511
if tm.reporter != nil {
@@ -526,20 +526,20 @@ func importParentLogAndGetDuration(fn string, out io.Writer) time.Duration {
526526
}
527527
defer file.Close()
528528

529-
defer out.Write([]byte("♻️ Re-running task as an incremental workspace prebuild\r\n\r\n"))
529+
defer out.Write([]byte("📦\bRe-running task for incremental prebuild\r\n\r\n"))
530530

531531
scanner := bufio.NewScanner(file)
532532
for scanner.Scan() {
533533
l := scanner.Text()
534-
if strings.Contains(l, "🍊 This task ran as a workspace prebuild") {
534+
if strings.Contains(l, "\bThis task ran as a workspace prebuild") {
535535
break
536536
}
537537
out.Write([]byte(l + "\n"))
538538
}
539539
if !scanner.Scan() {
540540
return 0
541541
}
542-
reg, err := regexp.Compile(`⏱️ Well done on saving (\d+) minute`)
542+
reg, err := regexp.Compile(`⏱️\bWell done on saving (\d+) minute`)
543543
if err != nil {
544544
return 0
545545
}

test/tests/components/ws-manager/prebuild_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ func TestPrebuildWorkspaceTaskFail(t *testing.T) {
190190

191191
const (
192192
prebuildLogPath string = "/workspace/.gitpod"
193-
prebuildLog string = "'🍊 This task ran as a workspace prebuild'"
193+
prebuildLog string = "'\bThis task ran as a workspace prebuild'"
194194
initTask string = "echo \"some output\" > someFile; sleep 10;"
195195
regularPrefix string = "ws-"
196196
)
@@ -889,7 +889,7 @@ func checkPVCObject(t *testing.T, api *integration.ComponentAPI, isPVCEnable boo
889889

890890
// checkPrebuildLogExist checks the prebuild log message exists
891891
func checkPrebuildLogExist(t *testing.T, cfg *envconf.Config, rsa *integration.RpcClient, ws *integration.LaunchWorkspaceDirectlyResult, wsRoot string) {
892-
// since the message '🍊 This task ran as a workspace prebuild' is generated by
892+
// since the message ' This task ran as a workspace prebuild' is generated by
893893
// a prebuild workspace supervisor, so we add a retry mechanism to make sure that we
894894
// won't check the message too earlier before the supervisor generated it.
895895
var (
@@ -914,7 +914,7 @@ func checkPrebuildLogExist(t *testing.T, cfg *envconf.Config, rsa *integration.R
914914

915915
t.Logf("cannot found the prebuild message %s in %s, err:%v, exitCode:%d, stdout:%s", prebuildLog, prebuildLogPath, err, grepResp.ExitCode, grepResp.Stdout)
916916

917-
// somehow, the prebuild log message '🍊 This task ran as a workspace prebuild' does not exists
917+
// somehow, the prebuild log message ' This task ran as a workspace prebuild' does not exists
918918
// we fall back to check the the init task message within the /workspace/.gitpod/prebuild-log-* or not
919919
var grepResp1 agent.ExecResponse
920920
var checkInitTaskMsg bool

0 commit comments

Comments
 (0)