Skip to content

Commit fb41408

Browse files
Furistoroboquat
authored andcommitted
[ws-daemon] Register metrics
1 parent a80ee4a commit fb41408

File tree

1 file changed

+3
-27
lines changed

1 file changed

+3
-27
lines changed

components/ws-daemon/pkg/daemon/daemon.go

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ func NewDaemon(config Config, reg prometheus.Registerer) (*Daemon, error) {
154154

155155
var mgr manager.Manager
156156
if config.WorkspaceController.Enabled {
157-
mgr, err := ctrl.NewManager(restCfg, ctrl.Options{
157+
mgr, err = ctrl.NewManager(restCfg, ctrl.Options{
158158
Scheme: scheme,
159159
Port: 9443,
160160
Namespace: config.Runtime.KubernetesNamespace,
@@ -175,6 +175,7 @@ func NewDaemon(config Config, reg prometheus.Registerer) (*Daemon, error) {
175175
UIDMapperConfig: config.Uidmapper,
176176
ContainerRuntime: containerRuntime,
177177
CGroupMountPoint: config.CPULimit.CGroupBasePath,
178+
MetricsRegistry: reg,
178179
})
179180
if err != nil {
180181
return nil, err
@@ -203,30 +204,6 @@ func NewDaemon(config Config, reg prometheus.Registerer) (*Daemon, error) {
203204
return nil, xerrors.Errorf("cannot create content service: %w", err)
204205
}
205206

206-
if config.WorkspaceController.Enabled {
207-
log.Info("enabling workspace CRD controller")
208-
209-
contentCfg := config.Content
210-
contentCfg.WorkingArea += config.WorkspaceController.WorkingAreaSuffix
211-
contentCfg.WorkingAreaNode += config.WorkspaceController.WorkingAreaSuffix
212-
213-
wsctrl, err := controller.NewWorkspaceController(mgr.GetClient(), controller.WorkspaceControllerOpts{
214-
NodeName: nodename,
215-
ContentConfig: contentCfg,
216-
UIDMapperConfig: config.Uidmapper,
217-
ContainerRuntime: containerRuntime,
218-
CGroupMountPoint: config.CPULimit.CGroupBasePath,
219-
MetricsRegistry: reg,
220-
})
221-
if err != nil {
222-
return nil, err
223-
}
224-
err = wsctrl.SetupWithManager(mgr)
225-
if err != nil {
226-
return nil, err
227-
}
228-
}
229-
230207
dsk := diskguard.FromConfig(config.DiskSpaceGuard, clientset, nodename)
231208

232209
hsts, err := hosts.FromConfig(config.Hosts, clientset, config.Runtime.KubernetesNamespace)
@@ -235,8 +212,7 @@ func NewDaemon(config Config, reg prometheus.Registerer) (*Daemon, error) {
235212
}
236213

237214
return &Daemon{
238-
Config: config,
239-
215+
Config: config,
240216
dispatch: dsptch,
241217
content: contentService,
242218
diskGuards: dsk,

0 commit comments

Comments
 (0)