Skip to content

Keep admin menu active when opening a user, project, or team #10499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Jun 7, 2022 · 3 comments
Closed

Keep admin menu active when opening a user, project, or team #10499

gtsiolis opened this issue Jun 7, 2022 · 3 comments
Labels
component: dashboard feature: admin dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jun 7, 2022

Problem to solve

Following up from #10309, currently when opening a user, project, or team in the /admin area the menu highlight disappears.

/admin/teams /admin/teams/c5895528-xyz
Screenshot 2022-06-07 at 12 18 46 PM (2) Screenshot 2022-06-07 at 12 20 14 PM (2)

Pasting below a relevant line code that could help:

const isAdminUI = window.location.pathname.startsWith("/admin");

Proposal

The menu item should remain active also when opening a user, project, or team in the /admin area.

@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 8, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Sep 9, 2022
@Devansu-Yadav
Copy link
Contributor

@gtsiolis Is this issue still prevalent, considering that we addressed this as part of #16307?

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 17, 2023

Thanks, @Devansu-Yadav!

This refers to the menu when you are viewing a specific user, workspace, etc, however, it definitely feels less critical and will be irrelevant if we merge the changes in #16423.

Let's close this and re-open a new issue if this is still needed! 📕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: admin dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

2 participants