Skip to content

What is the difference between /ide/bin/remote-cli/gitpod-code and /ide/bin/helpers/browser.sh #11739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghuntley opened this issue Jul 29, 2022 · 2 comments
Labels
editor: code (browser) meta: never-stale This issue can never become stale

Comments

@ghuntley
Copy link
Contributor

ghuntley commented Jul 29, 2022

Objective

Question:

  1. Do we have tech debt here that should be cleaned up?
  2. Which one should be documented on https://www.gitpod.io/docs/ides-and-editors/vscode-browser 👍
  3. export EDITOR is currently set to /ide/bin/remote-cli/gitpod-code
gitpod /workspace/website (main) $ cat /ide/bin/remote-cli/gitpod-code
#!/usr/bin/env sh
#
# Copyright (c) Microsoft Corporation. All rights reserved.
#
ROOT="$(dirname "$(dirname "$(dirname "$(readlink -f "$0")")")")"

APP_NAME="gitpod-code"
VERSION="1.69.2"
COMMIT="412debcdce97027594b55f85871951f0aa87c2fc"
EXEC_NAME="gitpod-code"
CLI_SCRIPT="$ROOT/out/server-cli.js"
"$ROOT/node" "$CLI_SCRIPT" "$APP_NAME" "$VERSION" "$COMMIT" "$EXEC_NAME" "$@"
gitpod /workspace/website (main) $ cat /ide/bin/helpers/browser.sh
#!/usr/bin/env sh
#
# Copyright (c) Microsoft Corporation. All rights reserved.
#
ROOT="$(dirname "$(dirname "$(dirname "$(readlink -f "$0")")")")"

APP_NAME="gitpod-code"
VERSION="1.69.2"
COMMIT="412debcdce97027594b55f85871951f0aa87c2fc"
EXEC_NAME="gitpod-code"
CLI_SCRIPT="$ROOT/out/server-cli.js"
"$ROOT/node" "$CLI_SCRIPT" "$APP_NAME" "$VERSION" "$COMMIT" "$EXEC_NAME" "--openExternal" "$@"
@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 2, 2022

Removed the ~feedback-issue label to avoid any confusion as feedback issues are used to gather feedback, suggestions, and experiences from users while iterating on a specific product feature.

Cross-posting also the recently updated issue template description in #11244.

@axonasif
Copy link
Member

Both scripts are calling the same parent script, the only difference is that the browser.sh is passing on an additional CLI argument: "--openExternal", which is why I think it's aliased browser.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor: code (browser) meta: never-stale This issue can never become stale
Projects
None yet
Development

No branches or pull requests

3 participants