Skip to content

Remove the pointer cursor on the timestamp column in team usage page #12581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Sep 1, 2022 · 3 comments · Fixed by #12699
Closed

Remove the pointer cursor on the timestamp column in team usage page #12581

gtsiolis opened this issue Sep 1, 2022 · 3 comments · Fixed by #12699
Assignees
Labels
component: dashboard feature: billing team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 1, 2022

Problem to solve

While we dropped the timestamp sorting order in usage in #12501, we left behind the cursor-pointer class on the column header.

See relevant diff.

Cc @AlexTugarev @easyCZ @svenefftinge @jldec

Proposal

Remove the pointer cursor on the timestamp column in team usage page.

Fix should be relatively easy:

diff --git a/components/dashboard/src/teams/TeamUsage.tsx b/components/dashboard/src/teams/TeamUsage.tsx
index 05429d90c..c86c0ff06 100644
--- a/components/dashboard/src/teams/TeamUsage.tsx
+++ b/components/dashboard/src/teams/TeamUsage.tsx
@@ -232,7 +232,7 @@ function TeamUsage() {
                                             <span>Credits</span>
                                         </ItemField>
                                         <ItemField className="my-auto" />
-                                        <ItemField className="col-span-3 my-auto cursor-pointer">
+                                        <ItemField className="my-auto">
                                             <span
                                                 className="flex my-auto"
                                                 onClick={() => setIsStartedTimeDescending(!isStartedTimeDescending)}
@gtsiolis gtsiolis added good-first-issue component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team feature: billing labels Sep 1, 2022
@skrmain
Copy link
Contributor

skrmain commented Sep 5, 2022

Hi @gtsiolis,

Can I work on the Issue...?

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 5, 2022

@skrmain Yes, any open issue is available for picking up. Just make sure there's no one assigned and there's not any work-in-progress PR linking back to an issue. 🏓

@skrmain
Copy link
Contributor

skrmain commented Sep 8, 2022

Hi @gtsiolis,

I have made the change and raised the PR #12699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: billing team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants