Skip to content

Wrong error message being displayed when running prebuild twice on same commit #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shaal opened this issue Mar 31, 2021 · 2 comments
Closed

Comments

@shaal
Copy link
Contributor

shaal commented Mar 31, 2021

Bug description

In upcoming version of Gitpod -
Running manual prebuild, when a prebuild is already running on the same commit, results in an error page with the wrong information of what's happening.

Unrecognized context: 'prebuild/https://github.com/shaal/gitpod-bug-repro'

In the current version of Gitpod, it works as expected,

We are having trouble parsing your context
Error: A prebuild is already running for this commit.

Steps to reproduce

Open a GitHub repo link, with the manual Gitpod prefix command /#prebuild/.
https://main.staging.gitpod-dev.com/#prebuild/https://github.com/shaal/gitpod-bug-repro
While this is running - open the same link, in another tab.

You will see that in the 2nd tab the error is: Unrecognized context: 'prebuild/https://github.com/shaal/gitpod-bug-repro'

Run the same process above, but in current version of Gitpod, and you'll see the correct error being displayed:
https://gitpod.io/#prebuild/https://github.com/shaal/gitpod-bug-repro

Expected behavior

Display the correct error message - that another prebuild for that commit is already running.

Example repository

Any repo would work, I used https://github.com/shaal/gitpod-bug-repro

[Upcoming Gitpod] Screenshot:
image

[Existing Gitpod] Screenshot:
image

@jankeromnes
Copy link
Contributor

jankeromnes commented Apr 1, 2021

Hi @shaal! Many thanks for reporting this issue.

Unfortunately, "Unrecognized context" is kind of a "catch all" for multiple possible problems. The full error is currently logged in the browser console, but I totally agree that the correct error message should also be visible on the page.

@jankeromnes jankeromnes self-assigned this Apr 1, 2021
@gtsiolis gtsiolis added this to the March 2021 milestone Apr 2, 2021
@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 7, 2021

This has been resolved in #3693. Thanks for reporting this @shaal!

@gtsiolis gtsiolis closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants