Skip to content

[proxy] Make sure we do not (long-term) cache error responses #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
geropl opened this issue Apr 7, 2021 · 2 comments · Fixed by #3922 or #3935
Closed

[proxy] Make sure we do not (long-term) cache error responses #3818

geropl opened this issue Apr 7, 2021 · 2 comments · Fixed by #3922 or #3935
Assignees
@aledbf
Labels
component: proxy

Comments

@geropl
Copy link
Member

geropl commented Apr 7, 2021

We recently introduced long-term caching for static assets.

While atm we have only a handful of resources under /static we should make sure that we do not accidently cache errors like 404s in the future, for instance by using a pattern like this: https://serverfault.com/a/690258
@geropl geropl added this to the [backlog] April 2021 milestone Apr 7, 2021
This was referenced Apr 13, 2021
Closed
Merged
@aledbf aledbf self-assigned this Apr 13, 2021
@akosyakov akosyakov reopened this Apr 14, 2021
@geropl
Copy link
Member Author

geropl commented Apr 14, 2021

@aledbf I'm not 100% sure it's fixed by #3922. What's the default behavior for caddy on error cases?

@akosyakov
Copy link
Member

It is still valid, we should apply https://caddy.community/t/correct-way-to-set-expires-on-caddy-2/7914/13?

@aledbf aledbf mentioned this issue Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aledbf aledbf

Labels
component: proxy
Projects
None yet
Milestone
No milestone
3 participants
@aledbf @akosyakov @geropl