Skip to content

Menu entry "About Gitpod" for Theia is missing an image #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kuniss opened this issue Apr 18, 2021 · 5 comments
Closed

Menu entry "About Gitpod" for Theia is missing an image #3989

kuniss opened this issue Apr 18, 2021 · 5 comments

Comments

@kuniss
Copy link

kuniss commented Apr 18, 2021

Bug description

Title says it all.

Steps to reproduce

Select menu entry Help -> About Gitpod.

Expected behavior

Image is shown.

Example repository

Any, I guess.
Else: https://github.com/kuniss/epsilon/

@kuniss
Copy link
Author

kuniss commented Apr 18, 2021

Bildschirmfoto vom 2021-04-18 11-54-21

@kuniss kuniss changed the title Menu entry "About Gitpod" for Theia is missing a image Menu entry "About Gitpod" for Theia is missing an image Apr 18, 2021
@axonasif
Copy link
Member

Bildschirmfoto vom 2021-04-18 11-54-21

That image block is expecting https://gitpod.io/images/gitpod-ddd.svg but it seems to be missing.
The image path is defined here

@gtsiolis
Copy link
Contributor

Nice catch @kuniss @Axim0s! ⚾

This has been removed in #3295 with the new dashboard changes.

Since we're now defaulting to VS Code for the default IDE (see relevant product roadmap item) and we're going to phase out Theia and only allow Theia as a custom IDE image (see relevant product roadmap item), it could make sense to also remove this menu entry altogether. Alternatively, replacing the broken image should also work.

What do you think @akosyakov? /cc @svenefftinge

@akosyakov
Copy link
Member

We are not going to make changes to Theia. We should either to reintroduce or redirect for images for time being. Or it is not fix and will be resolved when Theia goes aways.

@kuniss
Copy link
Author

kuniss commented Apr 19, 2021

Not be bothered! Not that important...
Just want to mentioned in case it may be important for the Gitpod team.
Just let it go it disappear with Theia going away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants