Skip to content

Make Docker-based workflows seamless #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sr229 opened this issue Apr 21, 2021 · 3 comments
Closed

Make Docker-based workflows seamless #4028

sr229 opened this issue Apr 21, 2021 · 3 comments
Labels
feature: docker in workspaces type: improvement Improves an existing feature or existing code

Comments

@sr229
Copy link

sr229 commented Apr 21, 2021

At the moment, we still require our workflows to invoke docker-up to even use Docker. This removes some of the benefits of having "less" to set-up on the workflow, since you still need to manually invoke docker-up everytime you want to work on a Docker project.

docker-up as much as possible should be invoked in the background instead of requiring the user to do it manually, since it doesn't make sense to call it from CLI when you expect Gitpod to do it for you.

@corneliusludmann corneliusludmann added feature: docker in workspaces type: improvement Improves an existing feature or existing code labels Apr 21, 2021
@akosyakov
Copy link
Member

fixed by #4018 :) ?

@csweichel
Copy link
Contributor

Thank you for bringing this up. Indeed, this is fixed by #4018 which basically makes docker available in every workspace without having to call docker-up first. You should see this feature land before the end of next week.

Closing this issue for now. If the aforementioned PR does not solve this issue for you, please reopen.

@sr229
Copy link
Author

sr229 commented Apr 21, 2021

Ran it on a local K3s instance and I can confirm it works! Are you guys speedrunning or what @csweichel? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: docker in workspaces type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

4 participants