Skip to content

Add empty state for project prebuilds #5022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Jul 30, 2021 · 4 comments · Fixed by #7882
Closed

Add empty state for project prebuilds #5022

gtsiolis opened this issue Jul 30, 2021 · 4 comments · Fixed by #7882
Assignees
Labels
component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team user experience

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 30, 2021

Problem to solve

Currently, when adding a project in a team a) the product does not surface previous prebuilds and b) the project may not have any previous prebuilds.

Proposal

To avoid having empty pages where it's not clear if the data does not exist or an error occurred while fetching the data we could add an empty state for the prebuilds page when adding a project.

A good first MVC (Minimum Viable Change) could be to reuse the same logic we've used in #4571 when searching members returns no members.

? <p className="pt-16 text-center">No members found</p>

Two more things to consider in this scope:

  1. The same could apply when a project is an empty repository and does not contain any active braches. 💡
  2. The same component could be used when searching for branches or prebuilds returns no results. 💡
BEFORE AFTER
Prebuilds BEFORE Prebuilds AFTER
@stale
Copy link

stale bot commented Nov 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 22, 2021
@gtsiolis
Copy link
Contributor Author

Marking this as never stale.

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Nov 25, 2021
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team labels Nov 25, 2021
@stale stale bot removed meta: stale This issue/PR is stale and will be closed soon labels Nov 25, 2021
@laushinka laushinka self-assigned this Jan 31, 2022
@laushinka
Copy link
Contributor

Also tackled in #7882

@gtsiolis
Copy link
Contributor Author

Closing this as it was resolved in #7882. Thanks @laushinka! 🏀

@gtsiolis gtsiolis moved this to Done in 🍎 WebApp Team Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team user experience
Projects
Archived in project
Status: Low hanging fruits 🍒
Development

Successfully merging a pull request may close this issue.

2 participants