Skip to content

[configuration] Don't suggest/allow starting another prebuild when one is running #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svenefftinge opened this issue Aug 26, 2021 · 3 comments · Fixed by #5474
Closed
Assignees
Labels
type: improvement Improves an existing feature or existing code user experience

Comments

@svenefftinge
Copy link
Member

In configuration I can start a prebuild. When that is running tze "Run Prebuild" button is still green and active.
When I click it I loose the current logs and see an error message, telling me that I cannot start a prebuild because one is running already.

@svenefftinge svenefftinge changed the title [configurartion] Don't suggest/allow starting another prebuild when one is running [configuration] Don't suggest/allow starting another prebuild when one is running Aug 26, 2021
@gtsiolis
Copy link
Contributor

The initial specs (#4948 (comment)) included a Cancel Prebuild when a prebuild was pending or running.
Does this sounds better? Cc @jankeromnes @svenefftinge

Pending or Running Prebuild
128853942-398e2820-d3ca-4711-84e7-c120a63c985e

@atduarte
Copy link
Contributor

Should the button in the Project > Prebuilds page have the same behavior? Related with #5374

@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 2, 2021

Okay, I tried implementing a Cancel Prebuild button in #5474, but ended up backpedalling because this would require a new server method (e.g. server.cancelPrebuild, next to server.triggerPrebuild) in order to properly set the Prebuild state as CANCELLED (otherwise, if you just call server.stopWorkspace(prebuildWorkspaceId) as I did, the prebuild will get "cancelled" but then show up as SUCCESSFUL in the UI 🤦).

That PR is already too big, so disabling the Run Prebuild button for now (only disabled when a prebuild is running) and leaving the Cancel Prebuild button/feature as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement Improves an existing feature or existing code user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants