Skip to content

[desktop] workspace timeouts if you close the browser tab prematurely #7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Dec 3, 2021 · 5 comments
Closed

[desktop] workspace timeouts if you close the browser tab prematurely #7057

ghost opened this issue Dec 3, 2021 · 5 comments

Comments

@ghost
Copy link

ghost commented Dec 3, 2021

Bug description

If you open a workspace in vscode and immediately close the tab it won't let you to connect.

Steps to reproduce

  1. Open a workspace.
  2. Open the workspace in VSCode. When vscode is open and prompts you to "Continue", close the gitpod tab.
  3. See error.

Workspace affected

No response

Expected behavior

Workspace should open no matter if the tab is open or closed.

Example repository

Any repo is valid

Anything else?

See the discord for more info

@akosyakov akosyakov changed the title VSCode Desktop: workspace timeouts if you close the browser tab prematurely [desktop] workspace timeouts if you close the browser tab prematurely Dec 3, 2021
@akosyakov akosyakov added editor: code (desktop) type: bug Something isn't working labels Dec 6, 2021
@akosyakov
Copy link
Member

It is going to be a problem for all desktop apps. Maybe we should avoid sending close event from ready screen if desktop app was opened. Or have a special one.

@ghost
Copy link
Author

ghost commented Jan 17, 2022

It is going to be a problem for all desktop apps. Maybe we should avoid sending close event from ready screen if desktop app was opened. Or have a special one.

Probably just vscode, due to how it works.

@stale
Copy link

stale bot commented Apr 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 19, 2022
@ghost
Copy link
Author

ghost commented Apr 19, 2022

don't stale

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Apr 19, 2022
@loujaybee
Copy link
Member

Thanks for raising @dragonDScript, I think this issue is a duplicate of:

Please watch that one for updates, we're actively looking into this one currently.

@loujaybee loujaybee closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants