Skip to content

[build] make werft fail early when the branch name is too long #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JanKoehnlein opened this issue Feb 18, 2022 · 5 comments
Closed

[build] make werft fail early when the branch name is too long #8304

JanKoehnlein opened this issue Feb 18, 2022 · 5 comments
Assignees

Comments

@JanKoehnlein
Copy link
Contributor

Is your feature request related to a problem? Please describe

If your branch name for of your PR is too long (>40chars), the certificates for the preview env will not be fetched and the preview env deployment will fail. This is a very late step in the werft build and the error message is usually only visible when you browse the raw logs.

Describe the behaviour you'd like

Werft should fail early and with a well visible error message.

Describe alternatives you've considered

We could also automatically shorten the domain name for the preview env, but I fear that this could open an attack vector via community PRs whose shortened name collides with an existing one.

Additional context

This is an error almost everybody has run into and even experienced Gitpodders stumble upon every now and then.

@svenefftinge
Copy link
Member

svenefftinge commented Feb 18, 2022

I'd be in favor of just shortening the identifier.

We could also automatically shorten the domain name for the preview env, but I fear that this could open an attack vector via community PRs whose shortened name collides with an existing one.

Let's figure out if such a possibility exists.

See also #8169

@mads-hartmann
Copy link
Contributor

I believe this is being handled by #8316 (at least the fail early part) /cc @wulfthimm

Lets track finding a way to support longer branch names (e.g. by shortening it as you suggest) in a separate issue (I'll create it)

@mads-hartmann
Copy link
Contributor

@wulfthimm I assigned this to you, please close it when you've merged your PR ☺️

@mads-hartmann
Copy link
Contributor

And here's the follow up issue https://github.com/gitpod-io/ops/issues/1252

@mads-hartmann
Copy link
Contributor

Closing this as we're now failing when branch names are too long. There's a separate issue to figure out how to support long branch names again https://github.com/gitpod-io/ops/issues/1252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants