Skip to content

"Prebuild in Progress" is often misleading or misbehaves. #8446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jldec opened this issue Feb 24, 2022 · 4 comments
Closed

"Prebuild in Progress" is often misleading or misbehaves. #8446

jldec opened this issue Feb 24, 2022 · 4 comments
Labels
team: webapp Issue belongs to the WebApp team

Comments

@jldec
Copy link
Contributor

jldec commented Feb 24, 2022

When a prebuild is in progress, users who open a workspace on that branch see a screen showing "Prebuild in Progress" (example below),

  1. Connecting to workspace logs... often fails so there is no way to see progress

  2. While preparing the prebuild (e.g. pulling a large base image) there are no workspace logs to connect to. It would be better to show the actual status (with progress if possible).

  3. When the prebuild is done (and showing as READY in the project), even if the "Prebuild in Progress" showed real logs, the screen often does not open a workspace, or show that the prebuild is ready, and there is no button to start a workspace using the new prebuild.

  4. Using browser refresh to start the workspace (after seeing the prebuild as READY in another browser tab) often still runs a new prebuild inside the workspace. It feels like the READY prebuild is often not used.

  5. If the prebuild fails for some reason e.g. a network timeout during npm install, this can result in all users seeing the "Prebuild in Progress" page until the prebuild timeout is reached (1 hour), or a new commit is triggered. I have not been able to reproduce this myself, but it was reported in [prebuild] Not able to consistently view logs and start related workspaces #8324.

Screenshot 2022-02-24 at 17 28 07


Screenshot 2022-02-24 at 17 35 16

@jldec jldec added the team: webapp Issue belongs to the WebApp team label Feb 24, 2022
@jldec
Copy link
Contributor Author

jldec commented Feb 24, 2022

cc: @jmls - related to #8324

@geropl
Copy link
Member

geropl commented Mar 1, 2022

I labelled this with good-first-issue not because it's easy to fix or of limited scope (more the opposite) but because it's relevant, yet a nice entry point to drill down into how our system works. Especially the webapp/IDE/workspace interaction.

@jldec
Copy link
Contributor Author

jldec commented Mar 1, 2022

See also investigation by @kylos101 in #8324 (comment)

@geropl
Copy link
Member

geropl commented May 31, 2022

@geropl geropl closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2022
@geropl geropl moved this to Done in 🍎 WebApp Team May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: webapp Issue belongs to the WebApp team
Projects
Status: No status
Development

No branches or pull requests

2 participants