Skip to content

Avatar access restriction causes overlaid text in project branch list. #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jldec opened this issue Mar 11, 2022 · 3 comments · Fixed by #8825
Closed

Avatar access restriction causes overlaid text in project branch list. #8755

jldec opened this issue Mar 11, 2022 · 3 comments · Fixed by #8825
Assignees
@jankeromnes
Labels
team: webapp Issue belongs to the WebApp team

Comments

@jldec
Copy link
Contributor

jldec commented Mar 11, 2022 •
edited
Loading

  • Connect gitpod.io to a self-hosted GitHub enterprise
  • Create a project
  • The branch list shows overlaid text where there are normally user avatars

Screenshot 2022-03-11 at 13 41 23
@jldec jldec added the team: webapp Issue belongs to the WebApp team label Mar 11, 2022
@jldec jldec moved this to Scheduled in 🍎 WebApp Team Mar 11, 2022
@jldec
Copy link
Contributor Author

jldec commented Mar 11, 2022

The image GET on the avatar url returns a 302 redirecting to the the login screen.
The CSS should be fixed to set a max size on the avatar width.

@gtsiolis
Copy link
Contributor

Nice catch, @jldec! ⚾

@jankeromnes
Copy link
Contributor

Will take a look today 😁

@jankeromnes jankeromnes self-assigned this Mar 15, 2022
@jankeromnes jankeromnes mentioned this issue Mar 15, 2022
Merged
Repository owner moved this from Scheduled to Done in 🍎 WebApp Team Mar 16, 2022
@jldec jldec mentioned this issue Mar 30, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jankeromnes jankeromnes

Labels
team: webapp Issue belongs to the WebApp team
Projects
🍎 WebApp Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[server] Improve GitHub Enterprise avatars handling gitpod-io/gitpod
3 participants
@gtsiolis @jankeromnes @jldec