From b3a11a907b96705a0d8364001c026e343477742c Mon Sep 17 00:00:00 2001 From: Milan Pavlik Date: Wed, 22 Jun 2022 11:42:25 +0000 Subject: [PATCH] [usage] Fix flaky test for ListWorkspacesByID --- components/usage/pkg/db/workspace_test.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/components/usage/pkg/db/workspace_test.go b/components/usage/pkg/db/workspace_test.go index de0fc40f9edfaa..8f86e904f25f35 100644 --- a/components/usage/pkg/db/workspace_test.go +++ b/components/usage/pkg/db/workspace_test.go @@ -87,14 +87,10 @@ func stringToVarchar(t *testing.T, s string) db.VarcharTime { } func TestListWorkspacesByID(t *testing.T) { - conn := db.ConnectForTests(t) - workspaces := []db.Workspace{ - dbtest.NewWorkspace(t, db.Workspace{ID: "gitpodio-gitpod-aaaaaaaaaaa"}), - dbtest.NewWorkspace(t, db.Workspace{ID: "gitpodio-gitpod-bbbbbbbbbbb"}), + dbtest.NewWorkspace(t, db.Workspace{}), + dbtest.NewWorkspace(t, db.Workspace{}), } - tx := conn.Create(workspaces) - require.NoError(t, tx.Error) for _, scenario := range []struct { Name string @@ -133,6 +129,11 @@ func TestListWorkspacesByID(t *testing.T) { }, } { t.Run(scenario.Name, func(t *testing.T) { + conn := db.ConnectForTests(t) + + tx := conn.Create(workspaces) + require.NoError(t, tx.Error) + results, err := db.ListWorkspacesByID(context.Background(), conn, scenario.QueryIDs) require.NoError(t, err) require.Len(t, results, scenario.Expected)