From a9e53c6b8196af9586ba1af6d25ef64535c72748 Mon Sep 17 00:00:00 2001 From: Harsh Singh Date: Thu, 13 Oct 2022 13:13:24 +0000 Subject: [PATCH] change: if statements to switch statements in dashboard --- components/dashboard/src/App.tsx | 86 +++++++++++++++----------------- 1 file changed, 41 insertions(+), 45 deletions(-) diff --git a/components/dashboard/src/App.tsx b/components/dashboard/src/App.tsx index 4923f150b9db43..74f052e8cb041c 100644 --- a/components/dashboard/src/App.tsx +++ b/components/dashboard/src/App.tsx @@ -428,21 +428,20 @@ function App() { { - const { resourceOrPrebuild } = props.match.params; - if (resourceOrPrebuild === "events") { - return ; - } - if (resourceOrPrebuild === "prebuilds") { - return ; - } - if (resourceOrPrebuild === "settings") { - return ; - } - if (resourceOrPrebuild === "variables") { - return ; + render={({ match }) => { + const { resourceOrPrebuild } = match.params; + switch (resourceOrPrebuild) { + case "events": + return ; + case "prebuilds": + return ; + case "settings": + return ; + case "variables": + return ; + default: + return resourceOrPrebuild ? : ; } - return resourceOrPrebuild ? : ; }} /> @@ -459,39 +458,36 @@ function App() { { - const { maybeProject, resourceOrPrebuild } = props.match.params; - if (maybeProject === "projects") { - return ; - } - if (maybeProject === "workspaces") { - return ; - } - if (maybeProject === "members") { - return ; - } - if (maybeProject === "settings") { - return ; + render={({ match }) => { + const { maybeProject, resourceOrPrebuild } = match.params; + switch (maybeProject) { + case "projects": + return ; + case "workspaces": + return ; + case "members": + return ; + case "settings": + return ; + case "billing": + return ; + case "usage": + return ; + default: + break; } - if (maybeProject === "billing") { - return ; - } - if (maybeProject === "usage") { - return ; - } - if (resourceOrPrebuild === "events") { - return ; - } - if (resourceOrPrebuild === "prebuilds") { - return ; - } - if (resourceOrPrebuild === "settings") { - return ; - } - if (resourceOrPrebuild === "variables") { - return ; + switch (resourceOrPrebuild) { + case "events": + return ; + case "prebuilds": + return ; + case "settings": + return ; + case "variables": + return ; + default: + return resourceOrPrebuild ? : ; } - return resourceOrPrebuild ? : ; }} />