From d1ac344818af6f1b69b88de42d42232fb9d24e61 Mon Sep 17 00:00:00 2001
From: Devansu Yadav <devansuyadav@gmail.com>
Date: Tue, 21 Mar 2023 12:00:38 +0000
Subject: [PATCH 1/3] [workspace] hide ide alert on stop phase (#11035)

---
 components/dashboard/src/start/StartWorkspace.tsx | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/components/dashboard/src/start/StartWorkspace.tsx b/components/dashboard/src/start/StartWorkspace.tsx
index 9888f9ff172b3d..8d0ef744feefe6 100644
--- a/components/dashboard/src/start/StartWorkspace.tsx
+++ b/components/dashboard/src/start/StartWorkspace.tsx
@@ -448,6 +448,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
         let phase: StartPhase | undefined = StartPhase.Preparing;
         let title = undefined;
         let isTimedOut = false;
+        let isStoppingOrStopped = false;
         let statusMessage = !!error ? undefined : <p className="text-base text-gray-400">Preparing workspace …</p>;
         const contextURL = ContextURL.getNormalizedURL(this.state.workspace)?.toString();
         const useLatest = !!this.state.workspaceInstance?.configuration?.ideConfig?.useLatest;
@@ -622,6 +623,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
 
             // Stopping means that the workspace is currently shutting down. It could go to stopped every moment.
             case "stopping":
+                isStoppingOrStopped = true;
                 if (isPrebuild) {
                     return (
                         <StartPage title="Prebuild in Progress">
@@ -659,6 +661,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
 
             // Stopped means the workspace ended regularly because it was shut down.
             case "stopped":
+                isStoppingOrStopped = true;
                 phase = StartPhase.Stopped;
                 if (this.state.hasImageBuildLogs) {
                     const restartWithDefaultImage = (event: React.MouseEvent) => {
@@ -710,7 +713,12 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
                 break;
         }
         return (
-            <StartPage phase={phase} error={error} title={title} showLatestIdeWarning={!isTimedOut && useLatest}>
+            <StartPage
+                phase={phase}
+                error={error}
+                title={title}
+                showLatestIdeWarning={!isTimedOut && !isStoppingOrStopped && useLatest}
+            >
                 {statusMessage}
             </StartPage>
         );

From 3e8d57dd6fe332825ea7328e1b03b290ae76222d Mon Sep 17 00:00:00 2001
From: Devansu Yadav <devansuyadav@gmail.com>
Date: Thu, 23 Mar 2023 11:40:14 +0000
Subject: [PATCH 2/3] [workspace] show ide alert on errors (#11035)

---
 components/dashboard/src/start/StartWorkspace.tsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/components/dashboard/src/start/StartWorkspace.tsx b/components/dashboard/src/start/StartWorkspace.tsx
index 8d0ef744feefe6..aca3fb5f19c0ed 100644
--- a/components/dashboard/src/start/StartWorkspace.tsx
+++ b/components/dashboard/src/start/StartWorkspace.tsx
@@ -449,6 +449,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
         let title = undefined;
         let isTimedOut = false;
         let isStoppingOrStopped = false;
+        let isError = error ? true : false;
         let statusMessage = !!error ? undefined : <p className="text-base text-gray-400">Preparing workspace …</p>;
         const contextURL = ContextURL.getNormalizedURL(this.state.workspace)?.toString();
         const useLatest = !!this.state.workspaceInstance?.configuration?.ideConfig?.useLatest;
@@ -717,7 +718,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
                 phase={phase}
                 error={error}
                 title={title}
-                showLatestIdeWarning={!isTimedOut && !isStoppingOrStopped && useLatest}
+                showLatestIdeWarning={isError || (!isTimedOut && !isStoppingOrStopped && useLatest)}
             >
                 {statusMessage}
             </StartPage>

From 7a0e99960f953a3c391f45b104bc267895bf1425 Mon Sep 17 00:00:00 2001
From: Devansu Yadav <devansuyadav@gmail.com>
Date: Tue, 28 Mar 2023 08:55:35 +0000
Subject: [PATCH 3/3] [workspace] refactor code for showing ide alert

---
 components/dashboard/src/start/StartWorkspace.tsx | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/components/dashboard/src/start/StartWorkspace.tsx b/components/dashboard/src/start/StartWorkspace.tsx
index aca3fb5f19c0ed..b0cdd5f6288c09 100644
--- a/components/dashboard/src/start/StartWorkspace.tsx
+++ b/components/dashboard/src/start/StartWorkspace.tsx
@@ -447,8 +447,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
         const withPrebuild = WithPrebuild.is(this.state.workspace?.context);
         let phase: StartPhase | undefined = StartPhase.Preparing;
         let title = undefined;
-        let isTimedOut = false;
-        let isStoppingOrStopped = false;
+        let isStoppingOrStoppedPhase = false;
         let isError = error ? true : false;
         let statusMessage = !!error ? undefined : <p className="text-base text-gray-400">Preparing workspace …</p>;
         const contextURL = ContextURL.getNormalizedURL(this.state.workspace)?.toString();
@@ -624,7 +623,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
 
             // Stopping means that the workspace is currently shutting down. It could go to stopped every moment.
             case "stopping":
-                isStoppingOrStopped = true;
+                isStoppingOrStoppedPhase = true;
                 if (isPrebuild) {
                     return (
                         <StartPage title="Prebuild in Progress">
@@ -662,7 +661,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
 
             // Stopped means the workspace ended regularly because it was shut down.
             case "stopped":
-                isStoppingOrStopped = true;
+                isStoppingOrStoppedPhase = true;
                 phase = StartPhase.Stopped;
                 if (this.state.hasImageBuildLogs) {
                     const restartWithDefaultImage = (event: React.MouseEvent) => {
@@ -680,7 +679,6 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
                 }
                 if (!isPrebuild && this.state.workspaceInstance.status.conditions.timeout) {
                     title = "Timed Out";
-                    isTimedOut = true;
                 }
                 statusMessage = (
                     <div>
@@ -718,7 +716,7 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
                 phase={phase}
                 error={error}
                 title={title}
-                showLatestIdeWarning={isError || (!isTimedOut && !isStoppingOrStopped && useLatest)}
+                showLatestIdeWarning={useLatest && (isError || !isStoppingOrStoppedPhase)}
             >
                 {statusMessage}
             </StartPage>