Skip to content

Release action is failing, insiders release is missing #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aptalca opened this issue Jun 9, 2022 · 4 comments
Closed

Release action is failing, insiders release is missing #364

aptalca opened this issue Jun 9, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@aptalca
Copy link

aptalca commented Jun 9, 2022

I noticed that all the insiders releases had disappeared from your repo.

I first opened a discussion entry to ask that question: #363

Then I realized you use a separate repo for releases and the github action there deletes all older insiders releases before pushing a new one. However, that action for the releases is now failing. It deleted all existing insiders releases, but it has not seemed to have pushed a new release (created the tag, but not the release).

https://github.com/gitpod-io/openvscode-releases/actions/runs/2464922104

Thanks

@filiptronicek
Copy link
Member

Hey @aptalca 👋, thanks for raising the issue! I will look into it.

@filiptronicek filiptronicek self-assigned this Jun 9, 2022
@filiptronicek filiptronicek added the bug Something isn't working label Jun 9, 2022
@filiptronicek
Copy link
Member

It looks like for some reason, the release was created as a draft. I published it and it is available at https://github.com/gitpod-io/openvscode-server/releases/tag/openvscode-server-insiders-v1.68.0.

I did not find any change of default behavior in the https://github.com/softprops/action-gh-release GitHub Action. It states, that the draft input gets inherited if there is an already-existing release for the tag, so maybe a previous release was marked as a draft by someone.

I will close the issue now, since it is most likely not going to happen next time, and if it does, I think explicitly setting draft to false in here will do the job.

@jeanp413
Copy link
Member

jeanp413 commented Jun 9, 2022

yeah I've seen this bug when the release is created as a draft, I think it happens because of some delay in the github API after deleting the old insiders, that's why I added this 30s delay, maybe github was a little slower than usual this time

@aptalca
Copy link
Author

aptalca commented Jun 9, 2022

Thanks for looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants