Rubocop

Author: gjtorikian

Gemfile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in graphql-docs.gemspec

Rakefile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 
@@ -31,7 +32,7 @@ task :console do
   require 'graphql-docs'
 
   def reload!
-    files = $LOADED_FEATURES.select { |feat| feat =~ /\/graphql-docs\// }
+    files = $LOADED_FEATURES.select { |feat| feat =~ %r{/graphql-docs/} }
     files.each { |file| load file }
   end
 

lib/graphql-docs.rb

@@ -10,7 +10,7 @@
 begin
   require 'awesome_print'
   require 'pry'
-rescue LoadError; end
+rescue LoadError; end # rubocop:disable Lint/SuppressedException
 module GraphQLDocs
   class << self
     def build(options)

lib/graphql-docs/configuration.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module GraphQLDocs
   module Configuration
     GRAPHQLDOCS_DEFAULTS = {
@@ -11,9 +12,9 @@ module Configuration
       output_dir: './output/',
       pipeline_config: {
         pipeline:
-          %i(ExtendedMarkdownFilter
-           EmojiFilter
-           TableOfContentsFilter),
+          %i[ExtendedMarkdownFilter
+             EmojiFilter
+             TableOfContentsFilter],
         context: {
           gfm: false,
           unsafe: true, # necessary for layout needs, given that it's all HTML templates
@@ -37,7 +38,7 @@ module Configuration
         unions: "#{File.dirname(__FILE__)}/layouts/graphql_unions.html",
         input_objects: "#{File.dirname(__FILE__)}/layouts/graphql_input_objects.html",
         scalars: "#{File.dirname(__FILE__)}/layouts/graphql_scalars.html",
-        directives: "#{File.dirname(__FILE__)}/layouts/graphql_directives.html",
+        directives: "#{File.dirname(__FILE__)}/layouts/graphql_directives.html"
       },
 
       landing_pages: {
@@ -59,7 +60,7 @@ module Configuration
         field_entry: '',
         deprecation_notice: '',
         notice: '',
-        notice_title: '',
+        notice_title: ''
       }
     }.freeze
   end

lib/graphql-docs/generator.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'erb'
 require 'sass'
 
@@ -14,14 +15,13 @@ def initialize(parsed_schema, options)
 
       @renderer = @options[:renderer].new(@parsed_schema, @options)
 
-      %i(operations objects mutations interfaces enums unions input_objects scalars directives).each do |sym|
-        if !File.exist?(@options[:templates][sym])
-          raise IOError, "`#{sym}` template #{@options[:templates][sym]} was not found"
-        end
+      %i[operations objects mutations interfaces enums unions input_objects scalars directives].each do |sym|
+        raise IOError, "`#{sym}` template #{@options[:templates][sym]} was not found" unless File.exist?(@options[:templates][sym])
+
         instance_variable_set("@graphql_#{sym}_template", ERB.new(File.read(@options[:templates][sym])))
       end
 
-      %i(index object query mutation interface enum union input_object scalar directive).each do |sym|
+      %i[index object query mutation interface enum union input_object scalar directive].each do |sym|
         if @options[:landing_pages][sym].nil?
           instance_variable_set("@#{sym}_landing_page", nil)
         elsif !File.exist?(@options[:landing_pages][sym])
@@ -33,7 +33,7 @@ def initialize(parsed_schema, options)
 
         if File.extname((@options[:landing_pages][sym])) == '.erb'
           opts = @options.merge(@options[:landing_pages][:variables]).merge(helper_methods)
-          if has_yaml?(landing_page_contents)
+          if yaml?(landing_page_contents)
             metadata, landing_page = split_into_metadata_and_contents(landing_page_contents, parse: false)
             erb_template = ERB.new(landing_page)
           else
@@ -60,45 +60,25 @@ def generate
       create_graphql_scalar_pages
       create_graphql_directive_pages
 
-      unless @graphql_index_landing_page.nil?
-        write_file('static', 'index', @graphql_index_landing_page, trim: false)
-      end
+      write_file('static', 'index', @graphql_index_landing_page, trim: false) unless @graphql_index_landing_page.nil?
 
-      unless @graphql_object_landing_page.nil?
-        write_file('static', 'object', @graphql_object_landing_page, trim: false)
-      end
+      write_file('static', 'object', @graphql_object_landing_page, trim: false) unless @graphql_object_landing_page.nil?
 
-      if !@graphql_query_landing_page.nil? && !has_query
-        write_file('operation', 'query', @graphql_query_landing_page, trim: false)
-      end
+      write_file('operation', 'query', @graphql_query_landing_page, trim: false) if !@graphql_query_landing_page.nil? && !has_query
 
-      unless @graphql_mutation_landing_page.nil?
-        write_file('operation', 'mutation', @graphql_mutation_landing_page, trim: false)
-      end
+      write_file('operation', 'mutation', @graphql_mutation_landing_page, trim: false) unless @graphql_mutation_landing_page.nil?
 
-      unless @graphql_interface_landing_page.nil?
-        write_file('static', 'interface', @graphql_interface_landing_page, trim: false)
-      end
+      write_file('static', 'interface', @graphql_interface_landing_page, trim: false) unless @graphql_interface_landing_page.nil?
 
-      unless @graphql_enum_landing_page.nil?
-        write_file('static', 'enum', @graphql_enum_landing_page, trim: false)
-      end
+      write_file('static', 'enum', @graphql_enum_landing_page, trim: false) unless @graphql_enum_landing_page.nil?
 
-      unless @graphql_union_landing_page.nil?
-        write_file('static', 'union', @graphql_union_landing_page, trim: false)
-      end
+      write_file('static', 'union', @graphql_union_landing_page, trim: false) unless @graphql_union_landing_page.nil?
 
-      unless @graphql_input_object_landing_page.nil?
-        write_file('static', 'input_object', @graphql_input_object_landing_page, trim: false)
-      end
+      write_file('static', 'input_object', @graphql_input_object_landing_page, trim: false) unless @graphql_input_object_landing_page.nil?
 
-      unless @graphql_scalar_landing_page.nil?
-        write_file('static', 'scalar', @graphql_scalar_landing_page, trim: false)
-      end
+      write_file('static', 'scalar', @graphql_scalar_landing_page, trim: false) unless @graphql_scalar_landing_page.nil?
 
-      unless @graphql_directive_landing_page.nil?
-        write_file('static', 'directive', @graphql_directive_landing_page, trim: false)
-      end
+      write_file('static', 'directive', @graphql_directive_landing_page, trim: false) unless @graphql_directive_landing_page.nil?
 
       if @options[:use_default_styles]
         assets_dir = File.join(File.dirname(__FILE__), 'layouts', 'assets')
@@ -117,23 +97,23 @@ def generate
     def create_graphql_query_pages
       graphql_operation_types.each do |query_type|
         metadata = ''
-        if query_type[:name] == graphql_root_types['query']
-          unless @options[:landing_pages][:query].nil?
-            query_landing_page = @options[:landing_pages][:query]
-            query_landing_page = File.read(query_landing_page)
-            if has_yaml?(query_landing_page)
-              pieces = yaml_split(query_landing_page)
-              pieces[2] = pieces[2].chomp
-              metadata = pieces[1, 3].join("\n")
-              query_landing_page = pieces[4]
-            end
-            query_type[:description] = query_landing_page
+        next unless query_type[:name] == graphql_root_types['query']
+
+        unless @options[:landing_pages][:query].nil?
+          query_landing_page = @options[:landing_pages][:query]
+          query_landing_page = File.read(query_landing_page)
+          if yaml?(query_landing_page)
+            pieces = yaml_split(query_landing_page)
+            pieces[2] = pieces[2].chomp
+            metadata = pieces[1, 3].join("\n")
+            query_landing_page = pieces[4]
           end
-          opts = default_generator_options(type: query_type)
-          contents = @graphql_operations_template.result(OpenStruct.new(opts).instance_eval { binding })
-          write_file('operation', 'query', metadata + contents)
-          return true
+          query_type[:description] = query_landing_page
         end
+        opts = default_generator_options(type: query_type)
+        contents = @graphql_operations_template.result(OpenStruct.new(opts).instance_eval { binding })
+        write_file('operation', 'query', metadata + contents)
+        return true
       end
       false
     end
@@ -229,7 +209,7 @@ def write_file(type, name, contents, trim: true)
         FileUtils.mkdir_p(path)
       end
 
-      if has_yaml?(contents)
+      if yaml?(contents)
         # Split data
         meta, contents = split_into_metadata_and_contents(contents)
         @options = @options.merge(meta)

lib/graphql-docs/helpers.rb

@@ -10,7 +10,7 @@ module Helpers
 
     def slugify(str)
       slug = str.gsub(SLUGIFY_PRETTY_REGEXP, '-')
-      slug.gsub!(%r!^\-|\-$!i, '')
+      slug.gsub!(/^\-|\-$/i, '')
       slug.downcase
     end
 
@@ -22,6 +22,7 @@ def include(filename, opts = {})
 
     def markdownify(string)
       return '' if string.nil?
+
       type = @options[:pipeline_config][:context][:unsafe] ? :UNSAFE : :DEFAULT
       ::CommonMarker.render_html(string, type).strip
     end
@@ -67,27 +68,23 @@ def graphql_directive_types
     end
 
     def split_into_metadata_and_contents(contents, parse: true)
-      opts = {}
       pieces = yaml_split(contents)
-      if pieces.size < 4
-        raise RuntimeError.new(
-          "The file '#{content_filename}' appears to start with a metadata section (three or five dashes at the top) but it does not seem to be in the correct format.",
-        )
-      end
+      raise "The file '#{content_filename}' appears to start with a metadata section (three or five dashes at the top) but it does not seem to be in the correct format." if pieces.size < 4
+
       # Parse
       begin
-        if parse
-          meta = YAML.load(pieces[2]) || {}
-        else
-          meta = pieces[2]
-        end
+        meta = if parse
+                 YAML.safe_load(pieces[2]) || {}
+               else
+                 pieces[2]
+               end
       rescue Exception => e # rubocop:disable Lint/RescueException
         raise "Could not parse YAML for #{name}: #{e.message}"
       end
       [meta, pieces[4]]
     end
 
-    def has_yaml?(contents)
+    def yaml?(contents)
       contents =~ /\A-{3,5}\s*$/
     end
 
@@ -114,6 +111,7 @@ def helper_methods
 
       Helpers.instance_methods.each do |name|
         next if name == :helper_methods
+
         @helper_methods[name] = method(name)
       end
 

lib/graphql-docs/parser.rb

@@ -232,7 +232,7 @@ def connection?(field)
     def sort_by_name!
       @processed_schema.each_pair do |key, value|
         next if value.empty?
-        next if key == :operation_types || key == :root_types
+        next if %i[operation_types root_types].include?(key)
 
         value.sort_by! { |o| o[:name] }
       end

lib/graphql-docs/renderer.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'html/pipeline'
 require 'yaml'
 require 'extended-markdown-filter'
@@ -13,9 +14,7 @@ def initialize(parsed_schema, options)
       @parsed_schema = parsed_schema
       @options = options
 
-      unless @options[:templates][:default].nil?
-        @graphql_default_layout = ERB.new(File.read(@options[:templates][:default]))
-      end
+      @graphql_default_layout = ERB.new(File.read(@options[:templates][:default])) unless @options[:templates][:default].nil?
 
       @pipeline_config = @options[:pipeline_config] || {}
       pipeline = @pipeline_config[:pipeline] || {}
@@ -40,10 +39,11 @@ def initialize(parsed_schema, options)
     end
 
     def render(contents, type: nil, name: nil, filename: nil)
-      opts = { base_url: @options[:base_url], output_dir: @options[:output_dir] }.merge({ type: type, name: name, filename: filename}).merge(helper_methods)
+      opts = { base_url: @options[:base_url], output_dir: @options[:output_dir] }.merge({ type: type, name: name, filename: filename }).merge(helper_methods)
 
       contents = to_html(contents, context: { filename: filename })
       return contents if @graphql_default_layout.nil?
+
       opts[:content] = contents
       @graphql_default_layout.result(OpenStruct.new(opts).instance_eval { binding })
     end
@@ -54,12 +54,12 @@ def to_html(string, context: {})
 
     private
 
-    def filter_key(s)
-      s.downcase
+    def filter_key(str)
+      str.downcase
     end
 
-    def filter?(f)
-      f < HTML::Pipeline::Filter
+    def filter?(filter)
+      filter < HTML::Pipeline::Filter
     rescue LoadError, ArgumentError
       false
     end

lib/graphql-docs/version.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module GraphQLDocs
-  VERSION = '1.9.1'.freeze
+  VERSION = '1.9.1'
 end

test/graphql-docs/generator_test.rb

@@ -6,7 +6,7 @@ class GeneratorTest < Minitest::Test
   class CustomRenderer
     def initialize(_, _); end
 
-    def render(contents, type: nil, name: nil, filename: nil)
+    def render(contents)
       to_html(contents)
     end
 
@@ -119,7 +119,7 @@ def test_that_custom_renderer_can_be_used
 
     contents = File.read(File.join(@output_dir, 'object', 'codeofconduct', 'index.html'))
 
-    assert_match /CoC!!!!!/, contents
+    assert_match(/CoC!!!!!/, contents)
   end
 
   def test_that_it_sets_classes
@@ -133,7 +133,7 @@ def test_that_it_sets_classes
 
     object = File.read File.join(@output_dir, 'object', 'codeofconduct', 'index.html')
 
-    assert_match /<div class="field-entry my-4">/, object
+    assert_match(/<div class="field-entry my-4">/, object)
   end
 
   def test_that_named_query_root_generates_fields
@@ -145,7 +145,7 @@ def test_that_named_query_root_generates_fields
 
     object = File.read File.join(@output_dir, 'operation', 'query', 'index.html')
 
-    assert_match /Do a thing/, object
+    assert_match(/Do a thing/, object)
   end
 
   def test_that_missing_landing_pages_are_reported
@@ -168,8 +168,8 @@ def test_that_erb_landing_pages_work
 
     object = File.read File.join(@output_dir, 'object', 'index.html')
 
-    assert_match /Variable Objects/, object
-    assert_match /wowie!!/, object
+    assert_match(/Variable Objects/, object)
+    assert_match(/wowie!!/, object)
   end
 
   def test_that_broken_yaml_is_caught