Skip to content

Commit 33cdece

Browse files
MarshallOfSoundgntem
authored andcommitted
src: expose TraceEventHelper with NODE_EXTERN
As node requires a tracing controller to be initialized embedders need access to the TraceEventHelper so that we can actually set the tracing controller. Refs: https://github.com/electron/electron/commit/0e5b6f93000e4718c9e35332ddbd0f6b76cdd585/#diff-89b287b2edd0a02dddae60cb26157f47 PR-URL: nodejs#28724 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 4ff327f commit 33cdece

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/tracing/trace_event.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,9 @@ const int kZeroNumArgs = 0;
310310
const decltype(nullptr) kGlobalScope = nullptr;
311311
const uint64_t kNoId = 0;
312312

313-
class TraceEventHelper {
313+
// Extern (for now) because embedders need access to TraceEventHelper.
314+
// Refs: https://github.com/nodejs/node/pull/28724
315+
class NODE_EXTERN TraceEventHelper {
314316
public:
315317
static TracingController* GetTracingController();
316318
static Agent* GetAgent();

0 commit comments

Comments
 (0)