Skip to content

Copy build files to build/desktop instead of desktop/build/outputs #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
provokateurin opened this issue Aug 25, 2019 · 6 comments
Closed
Labels
enhancement New feature or request hover

Comments

@provokateurin
Copy link
Member

All other platforms copy their build files to build/platform. Hover copies them to desktop/build/outputs.
They should be under build/desktop.

@pchampio
Copy link
Member

We are considering changing directory named created by hover from desktop to go, #209.
We aren't part of the flutter team, so I don't like to interfere too much with the current directory layout.

That been said, the build directory is ignored in the .gitignore file, copying hover build files to build/go shouldn't cause any issue. It is also better for cleaning because flutter clean will delete the files created by hover

@GeertJohan
Copy link
Member

See go-flutter-desktop/hover#14

@stuartmorgan-g
Copy link

FYI, there are ongoing changes to the way build artifacts are handled (e.g., intermediate files are in some cases being moved to .dart_tool). If the goal is to be consistent with the way flutter builds are managed, be aware that that's a moving target.

@stuartmorgan-g
Copy link

Longer term, flutter/flutter#25377 should hopefully be the solution for things like this. There's ongoing discussion about making flutter extensible in ways that would allow a lot of what is currently hover to become a plugin to flutter instead. Then build output for all platforms, officially supported or not, could be managed in a coherent way by the same tool :)

@GeertJohan
Copy link
Member

That sounds great @stuartmorgan!

I agree with @Drakirus about not interfering with the directory layout. Other directories in a flutter project are "owned" by other tools. Inside the go directory (now still desktop) we can do what we want without much chance of conflicts.

@GeertJohan
Copy link
Member

Closing this issue, we'll stick with the go folder for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hover
Development

No branches or pull requests

4 participants