Fix webhook bug (#10427)

lunny · techknowlogick · web-flow · commit 542bd59239d9 · 2020-02-23T13:49:40.000-05:00
Co-authored-by: techknowlogick &lt;matti@mdranta.net&gt;
diff --git a/modules/notification/webhook/webhook.go b/modules/notification/webhook/webhook.go
@@ -691,12 +691,12 @@ func (m *webhookNotifier) NotifyDeleteRef(pusher *models.User, repo *models.Repo
 
 	if err := webhook_module.PrepareWebhooks(repo, models.HookEventDelete, &api.DeletePayload{
 		Ref:        refName,
-		RefType:    "branch",
+		RefType:    refType,
 		PusherType: api.PusherTypeUser,
 		Repo:       apiRepo,
 		Sender:     apiPusher,
 	}); err != nil {
-		log.Error("PrepareWebhooks.(delete branch): %v", err)
+		log.Error("PrepareWebhooks.(delete %s): %v", refType, err)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -691,12 +691,12 @@ func (m webhookNotifier) NotifyDeleteRef(pusher models.User, repo *models.Repo`
`691`	`691`
`692`	`692`	`if err := webhook_module.PrepareWebhooks(repo, models.HookEventDelete, &api.DeletePayload{`
`693`	`693`	`Ref: refName,`
`694`		`- RefType: "branch",`
	`694`	`+ RefType: refType,`
`695`	`695`	`PusherType: api.PusherTypeUser,`
`696`	`696`	`Repo: apiRepo,`
`697`	`697`	`Sender: apiPusher,`
`698`	`698`	`}); err != nil {`
`699`		`- log.Error("PrepareWebhooks.(delete branch): %v", err)`
	`699`	`+ log.Error("PrepareWebhooks.(delete %s): %v", refType, err)`
`700`	`700`	`}`
`701`	`701`	`}`
`702`	`702`