Skip to content

Commit 63d5e76

Browse files
Add missing test case and fix typo in tests (#24915)
This PR adds a missing assertion in the `TestGetOrgUsersByOrgID` function. It also incidentally fixes a small typo.
1 parent 2250ddd commit 63d5e76

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

models/organization/org_test.go

+6
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,12 @@ func TestGetOrgUsersByOrgID(t *testing.T) {
265265
UID: 4,
266266
IsPublic: false,
267267
}, *orgUsers[1])
268+
assert.Equal(t, organization.OrgUser{
269+
ID: orgUsers[2].ID,
270+
OrgID: 3,
271+
UID: 28,
272+
IsPublic: true,
273+
}, *orgUsers[2])
268274
}
269275

270276
orgUsers, err = organization.GetOrgUsersByOrgID(db.DefaultContext, &organization.FindOrgMembersOpts{

models/organization/org_user_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ func TestUserListIsPublicMember(t *testing.T) {
8585
{22, map[int64]bool{}},
8686
}
8787
for _, v := range tt {
88-
t.Run(fmt.Sprintf("IsPublicMemberOfOrdIg%d", v.orgid), func(t *testing.T) {
88+
t.Run(fmt.Sprintf("IsPublicMemberOfOrgId%d", v.orgid), func(t *testing.T) {
8989
testUserListIsPublicMember(t, v.orgid, v.expected)
9090
})
9191
}
@@ -112,7 +112,7 @@ func TestUserListIsUserOrgOwner(t *testing.T) {
112112
{22, map[int64]bool{}}, // No member
113113
}
114114
for _, v := range tt {
115-
t.Run(fmt.Sprintf("IsUserOrgOwnerOfOrdIg%d", v.orgid), func(t *testing.T) {
115+
t.Run(fmt.Sprintf("IsUserOrgOwnerOfOrgId%d", v.orgid), func(t *testing.T) {
116116
testUserListIsUserOrgOwner(t, v.orgid, v.expected)
117117
})
118118
}

0 commit comments

Comments
 (0)