Skip to content

Commit 64faece

Browse files
authored
Fix UI Spacing Errors in mirror settings (#28990)
1 parent 4989ad0 commit 64faece

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

options/locale/locale_en-US.ini

+1
Original file line numberDiff line numberDiff line change
@@ -2013,6 +2013,7 @@ settings.mirror_settings.docs.doc_link_title = How do I mirror repositories?
20132013
settings.mirror_settings.docs.doc_link_pull_section = the "Pulling from a remote repository" section of the documentation.
20142014
settings.mirror_settings.docs.pulling_remote_title = Pulling from a remote repository
20152015
settings.mirror_settings.mirrored_repository = Mirrored repository
2016+
settings.mirror_settings.pushed_repository = Pushed repository
20162017
settings.mirror_settings.direction = Direction
20172018
settings.mirror_settings.direction.pull = Pull
20182019
settings.mirror_settings.direction.push = Push

templates/repo/settings/options.tmpl

+14-3
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,9 @@
105105
{{else}}
106106
{{ctx.Locale.Tr "repo.settings.mirror_settings.docs.no_new_mirrors"}} {{ctx.Locale.Tr "repo.settings.mirror_settings.docs.can_still_use"}}<br>
107107
{{end}}
108+
109+
{{if .Repository.IsMirror}}
108110
<table class="ui table">
109-
{{if $existingPushMirror}}
110111
<thead>
111112
<tr>
112113
<th style="width:40%">{{ctx.Locale.Tr "repo.settings.mirror_settings.mirrored_repository"}}</th>
@@ -200,8 +201,18 @@
200201
</td>
201202
</tr>
202203
</tbody>
203-
<thead><tr><th colspan="4"></th></tr></thead>
204-
{{end}}{{/* end if: IsMirror */}}
204+
</table>
205+
{{end}}{{/* end if: IsMirror */}}
206+
207+
<table class="ui table">
208+
<thead>
209+
<tr>
210+
<th style="width:40%">{{ctx.Locale.Tr "repo.settings.mirror_settings.pushed_repository"}}</th>
211+
<th>{{ctx.Locale.Tr "repo.settings.mirror_settings.direction"}}</th>
212+
<th>{{ctx.Locale.Tr "repo.settings.mirror_settings.last_update"}}</th>
213+
<th></th>
214+
</tr>
215+
</thead>
205216
<tbody>
206217
{{range .PushMirrors}}
207218
<tr>

0 commit comments

Comments
 (0)