Fix nil context user (#9099)

jolheiser · zeripath · commit 8f49b1232a0e · 2019-11-20T19:44:35.000Z
Signed-off-by: jolheiser &lt;john.olheiser@gmail.com&gt;
diff --git a/modules/context/repo.go b/modules/context/repo.go
@@ -204,7 +204,13 @@ func RetrieveTemplateRepo(ctx *Context, repo *models.Repository) {
 		return
 	}
 
-	if !repo.TemplateRepo.CheckUnitUser(ctx.User.ID, ctx.User.IsAdmin, models.UnitTypeCode) {
+	perm, err := models.GetUserRepoPermission(repo.TemplateRepo, ctx.User)
+	if err != nil {
+		ctx.ServerError("GetUserRepoPermission", err)
+		return
+	}
+
+	if !perm.CanRead(models.UnitTypeCode) {
 		repo.TemplateID = 0
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,13 @@ func RetrieveTemplateRepo(ctx Context, repo models.Repository) {`
`204`	`204`	`return`
`205`	`205`	`}`
`206`	`206`
`207`		`- if !repo.TemplateRepo.CheckUnitUser(ctx.User.ID, ctx.User.IsAdmin, models.UnitTypeCode) {`
	`207`	`+ perm, err := models.GetUserRepoPermission(repo.TemplateRepo, ctx.User)`
	`208`	`+ if err != nil {`
	`209`	`+ ctx.ServerError("GetUserRepoPermission", err)`
	`210`	`+ return`
	`211`	`+ }`
	`212`	`+`
	`213`	`+ if !perm.CanRead(models.UnitTypeCode) {`
`208`	`214`	`repo.TemplateID = 0`
`209`	`215`	`}`
`210`	`216`	`}`