Skip to content

Commit b07dfcc

Browse files
Refactor Dockerfile
1. Use `apk -U --no-cache add` instead of `apk update` + `apk add` + manually cache clean up. 2. Separate package installation and user, group setup, the combination to reduce a docker image layer didn't bring benefits here, only makes Dockerfiles more complex.
1 parent cebe3a6 commit b07dfcc

File tree

3 files changed

+9
-18
lines changed

3 files changed

+9
-18
lines changed

Dockerfile

+3-6
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ MAINTAINER Thomas Boerger <[email protected]>
33

44
EXPOSE 22 3000
55

6-
RUN apk update && \
7-
apk add \
6+
RUN apk -U --no-cache add \
87
su-exec \
98
ca-certificates \
109
sqlite \
@@ -14,10 +13,8 @@ RUN apk update && \
1413
s6 \
1514
curl \
1615
openssh \
17-
tzdata && \
18-
rm -rf \
19-
/var/cache/apk/* && \
20-
addgroup \
16+
tzdata
17+
RUN addgroup \
2118
-S -g 1000 \
2219
git && \
2320
adduser \

Dockerfile.aarch64

+3-6
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ FROM aarch64/alpine:3.5
22

33
EXPOSE 22 3000
44

5-
RUN apk update && \
6-
apk add \
5+
RUN apk -U --no-cache add \
76
su-exec \
87
ca-certificates \
98
sqlite \
@@ -13,10 +12,8 @@ RUN apk update && \
1312
s6 \
1413
curl \
1514
openssh \
16-
tzdata && \
17-
rm -rf \
18-
/var/cache/apk/* && \
19-
addgroup \
15+
tzdata
16+
RUN addgroup \
2017
-S -g 1000 \
2118
git && \
2219
adduser \

Dockerfile.rpi

+3-6
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ MAINTAINER Thomas Boerger <[email protected]>
33

44
EXPOSE 22 3000
55

6-
RUN apk update && \
7-
apk add \
6+
RUN apk -U --no-cache add \
87
su-exec \
98
ca-certificates \
109
sqlite \
@@ -14,10 +13,8 @@ RUN apk update && \
1413
s6 \
1514
curl \
1615
openssh \
17-
tzdata && \
18-
rm -rf \
19-
/var/cache/apk/* && \
20-
addgroup \
16+
tzdata
17+
RUN addgroup
2118
-S -g 1000 \
2219
git && \
2320
adduser \

0 commit comments

Comments
 (0)