Skip to content

The gogit implementation of git notes differs from the nogogit implementation #16657

Closed
@nitul1991

Description

@nitul1991
Contributor
  • Gitea version (or commit ref): 1dc41c4
  • Git version: 2.32.0
  • Operating system: macOS Catalina version 10.15.6
  • I built gitea from source and ran the tests via the command-line.
  • Database (use [x]):
    • PostgreSQL
      MySQL
      MSSQL
      SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
      No
  • Log gist:

Description

Whilst working on the issue #15373, I discovered that the implementation of the gogit version of git notes differs from the no-gogit version when a non existent commit ID is passed to the function GitNote.
I brought this up on Discord and @zeripath suggested that I provide a fix for this issue in a separate PR so that it can be backported to version 1.15.

Activity

added a commit that references this issue on Aug 9, 2021
caed084
added a commit that references this issue on Aug 9, 2021
e483ec8
added a commit that references this issue on Aug 24, 2021
8eab16d
locked and limited conversation to collaborators on Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @nitul1991

      Issue actions

        The gogit implementation of git notes differs from the nogogit implementation · Issue #16657 · go-gitea/gitea