Skip to content

Inputs for login/auth source dosnt get trimmed on save #21005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mai-Lapyst opened this issue Aug 31, 2022 · 2 comments
Open

Inputs for login/auth source dosnt get trimmed on save #21005

Mai-Lapyst opened this issue Aug 31, 2022 · 2 comments
Labels

Comments

@Mai-Lapyst
Copy link
Contributor

Description

The values of the input fields in the admin page for editing auth-sources (i.e. http://localhost:3000/admin/auths/1 ) aren't trimed when saveing.

The only time the value get's trimmed is when the page is reloaded, then the input fields contain the proper trimmed value's and a save will then correctly write the values to the database.

Gitea Version

1.17.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Binary distribution of 1.17.1

Database

SQLite

@zeripath
Copy link
Contributor

zeripath commented Sep 1, 2022

as far as I'm aware, almost no inputs are whitespace trimmed across Gitea.

Perhaps in general we should be whitespace trimming, but I guess I'm confused as to why this is a particular issue related to this page?

@Mai-Lapyst
Copy link
Contributor Author

When gitea really does no whitespace trimming across the whole application, then this issue maybe need to be converted to include all of gitea.

I just found it on that page and honestly didn't looked into other parts of gitea to test if the issue also exists there.

@lunny lunny modified the milestones: 1.17.2, 1.17.3 Sep 5, 2022
@6543 6543 modified the milestones: 1.17.3, 1.17.4 Oct 13, 2022
@lunny lunny modified the milestones: 1.17.4, 1.17.5 Dec 21, 2022
@lunny lunny removed this from the 1.17.5 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants