From 107fb731e797ac4f3f3a871863315a3dc00eb070 Mon Sep 17 00:00:00 2001
From: Jimmy Praet <jimmy.praet@telenet.be>
Date: Tue, 5 Jan 2021 19:32:50 +0100
Subject: [PATCH 1/2] Check permission for the appropriate unit type
Fixes false positives for "User created Issues in Repository which they no longer have access to" errors
---
routers/user/home.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/routers/user/home.go b/routers/user/home.go
index 952f5cdb3a34c..149e9bc482889 100644
--- a/routers/user/home.go
+++ b/routers/user/home.go
@@ -551,7 +551,7 @@ func Issues(ctx *context.Context) {
ctx.ServerError("GetUserRepoPermission", fmt.Errorf("[%d]%v", repoID, err))
return
}
- if !perm.CanRead(models.UnitTypeIssues) {
+ if !perm.CanRead(unitType) {
log.Error("User created Issues in Repository which they no longer have access to: [%d]", repoID)
}
}
From 23d4ab1bfe4a87e4cb31aab7f1e13579244359ea Mon Sep 17 00:00:00 2001
From: Jimmy Praet <jimmy.praet@telenet.be>
Date: Tue, 5 Jan 2021 21:35:41 +0100
Subject: [PATCH 2/2] change log level to Debug
---
routers/user/home.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/routers/user/home.go b/routers/user/home.go
index 149e9bc482889..2b59b971aa509 100644
--- a/routers/user/home.go
+++ b/routers/user/home.go
@@ -552,7 +552,7 @@ func Issues(ctx *context.Context) {
return
}
if !perm.CanRead(unitType) {
- log.Error("User created Issues in Repository which they no longer have access to: [%d]", repoID)
+ log.Debug("User created Issues in Repository which they no longer have access to: [%d]", repoID)
}
}
}