From ab94220f9e5172eb734e06f49453a97cd1e04dca Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Tue, 21 Jun 2022 18:30:35 +0200 Subject: [PATCH 1/2] fix #19936 --- routers/web/repo/release.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go index 666294631ced5..f181c17fc09fc 100644 --- a/routers/web/repo/release.go +++ b/routers/web/repo/release.go @@ -98,7 +98,12 @@ func releasesOrTags(ctx *context.Context, isTagList bool) { listOptions.PageSize = setting.API.MaxResponseItems } - tags, err := ctx.Repo.GitRepo.GetTags(listOptions.GetStartEnd()) + tagListStart, tagListEnd := listOptions.GetStartEnd() + if !isTagList { + // tags are used for compare feature witch needs all tags + tagListStart, tagListEnd = 0, 0 + } + tags, err := ctx.Repo.GitRepo.GetTags(tagListStart, tagListEnd) if err != nil { ctx.ServerError("GetTags", err) return From 3f358c24b001ce8a1791e3982308d47c1fd89135 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Tue, 21 Jun 2022 19:08:41 +0200 Subject: [PATCH 2/2] code-style nits --- routers/web/repo/release.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go index f181c17fc09fc..df953fd0b95f7 100644 --- a/routers/web/repo/release.go +++ b/routers/web/repo/release.go @@ -98,11 +98,13 @@ func releasesOrTags(ctx *context.Context, isTagList bool) { listOptions.PageSize = setting.API.MaxResponseItems } - tagListStart, tagListEnd := listOptions.GetStartEnd() - if !isTagList { - // tags are used for compare feature witch needs all tags - tagListStart, tagListEnd = 0, 0 + // TODO(20073) tags are used for compare feature witch needs all tags + // filtering is doen at the client side atm + tagListStart, tagListEnd := 0, 0 + if isTagList { + tagListStart, tagListEnd = listOptions.GetStartEnd() } + tags, err := ctx.Repo.GitRepo.GetTags(tagListStart, tagListEnd) if err != nil { ctx.ServerError("GetTags", err)