From dc4c5c5c4d88b33d9f47ff920f34619ae5c8d4f5 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Tue, 21 Jun 2022 18:30:35 +0200 Subject: [PATCH 1/3] Release page show all tags in compare dropdown (#20070) --- routers/web/repo/release.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go index 806880280827c..33ca1c5bb1061 100644 --- a/routers/web/repo/release.go +++ b/routers/web/repo/release.go @@ -98,7 +98,12 @@ func releasesOrTags(ctx *context.Context, isTagList bool) { listOptions.PageSize = setting.API.MaxResponseItems } - tags, err := ctx.Repo.GitRepo.GetTags(listOptions.GetStartEnd()) + tagListStart, tagListEnd := listOptions.GetStartEnd() + if !isTagList { + // tags are used for compare feature witch needs all tags + tagListStart, tagListEnd = 0, 0 + } + tags, err := ctx.Repo.GitRepo.GetTags(tagListStart, tagListEnd) if err != nil { ctx.ServerError("GetTags", err) return From f771cb6051cd73ac66ab986f7803d8876e5b1825 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Tue, 21 Jun 2022 18:37:23 +0200 Subject: [PATCH 2/3] update changelog as it not released jet --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c8143a92b19e4..8d8d7acfef13a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,9 +4,10 @@ This changelog goes through all the changes that have been made in each release without substantial changes to our git log; to see the highlights of what has been added to each release, please refer to the [blog](https://blog.gitea.io). -## [1.16.9](https://github.com/go-gitea/gitea/releases/tag/1.16.9) - 2022-06-20 +## [1.16.9](https://github.com/go-gitea/gitea/releases/tag/v1.16.9) - 2022-06-21 * BUGFIXES + * Release page show all tags in compare dropdown (#20070) (#20071) * Fix permission check for delete tag (#19985) (#20001) * Only log non ErrNotExist errors in git.GetNote (#19884) (#19905) * Use exact search instead of fuzzy search for branch filter dropdown (#19885) (#19893) From 9d07b230f89ddda641c59bbaf5e5dc916bcb73b7 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Tue, 21 Jun 2022 19:08:41 +0200 Subject: [PATCH 3/3] code-style nits --- routers/web/repo/release.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go index 33ca1c5bb1061..781ef55455ab5 100644 --- a/routers/web/repo/release.go +++ b/routers/web/repo/release.go @@ -98,11 +98,13 @@ func releasesOrTags(ctx *context.Context, isTagList bool) { listOptions.PageSize = setting.API.MaxResponseItems } - tagListStart, tagListEnd := listOptions.GetStartEnd() - if !isTagList { - // tags are used for compare feature witch needs all tags - tagListStart, tagListEnd = 0, 0 + // TODO(20073) tags are used for compare feature witch needs all tags + // filtering is doen at the client side atm + tagListStart, tagListEnd := 0, 0 + if isTagList { + tagListStart, tagListEnd = listOptions.GetStartEnd() } + tags, err := ctx.Repo.GitRepo.GetTags(tagListStart, tagListEnd) if err != nil { ctx.ServerError("GetTags", err)