From 1682f196bbb83dbf8fb9bbea16cbf75f6606ec7f Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:09:11 -0400 Subject: [PATCH 01/11] Update golangci-lint to v1.17.1 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3d81ebe606dff..ead1ddaf065bb 100644 --- a/Makefile +++ b/Makefile @@ -473,6 +473,6 @@ pr: golangci-lint: @hash golangci-lint > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ export BINARY="golangci-lint"; \ - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(GOPATH)/bin v1.16.0; \ + curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(GOPATH)/bin v1.17.1; \ fi golangci-lint run From 26e46cb3a2fe2cedec4e94bf20eb15eb5b3ee5fd Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:22:21 -0400 Subject: [PATCH 02/11] fix misspell --- .golangci.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.golangci.yml b/.golangci.yml index 82d0e46694e1d..e3a270f98ab12 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -95,3 +95,11 @@ issues: linters: - misspell text: '`Destory` is a misspelling of `Destroy`' + - path: modules/setting/repository.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: modules/setting/setting.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' From f00b31558fd05365652fce5c1b5e7d68f5782b22 Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:25:53 -0400 Subject: [PATCH 03/11] update deadline time --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index ead1ddaf065bb..de2692d6a8e7d 100644 --- a/Makefile +++ b/Makefile @@ -475,4 +475,4 @@ golangci-lint: export BINARY="golangci-lint"; \ curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(GOPATH)/bin v1.17.1; \ fi - golangci-lint run + golangci-lint run --deadline=3m From e0419dead66315ffe6d81b6539b17ea9c952478c Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:38:04 -0400 Subject: [PATCH 04/11] more misspell fix --- .golangci.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.golangci.yml b/.golangci.yml index e3a270f98ab12..bdc4e0ef96cff 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -103,3 +103,15 @@ issues: linters: - misspell text: '`Unknwon` is a misspelling of `Unknown`' + - path: modules/options/dynamic.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: models/migrations/migrations.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: models/migrations/v13.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' From 3b830438a8fcfb09bfdb3104f6e2db7e6dcfd353 Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:40:18 -0400 Subject: [PATCH 05/11] more misspell --- .golangci.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.golangci.yml b/.golangci.yml index bdc4e0ef96cff..5bfc88fc15aba 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -115,3 +115,15 @@ issues: linters: - misspell text: '`Unknwon` is a misspelling of `Unknown`' + - path: models/migrations/v19.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: models/migrations/v21.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: models/migrations/v22.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' From 715d2787502f7739e1a06bbbe2dbeaf58f4eea1b Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:42:54 -0400 Subject: [PATCH 06/11] more misspell --- .golangci.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.golangci.yml b/.golangci.yml index 5bfc88fc15aba..45e30491f8de2 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -127,3 +127,15 @@ issues: linters: - misspell text: '`Unknwon` is a misspelling of `Unknown`' + - path: models/migrations/v26.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: models/migrations/v25.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: modules/templates/dynamic.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown` From d1eecaa3a2a5e0f4d74d903b9b244fcb0b2a6d39 Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:44:48 -0400 Subject: [PATCH 07/11] Update .golangci.yml From 9cd336024de7cf1a0aba12c210594c3e7a8ddf16 Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:45:49 -0400 Subject: [PATCH 08/11] Update .golangci.yml --- .golangci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 45e30491f8de2..7bc0320e1065a 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -138,4 +138,4 @@ issues: - path: modules/templates/dynamic.go linters: - misspell - text: '`Unknwon` is a misspelling of `Unknown` + text: '`Unknwon` is a misspelling of `Unknown`' From 03a350865c0fa70f758c71fd6624a2417d5fd53e Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:49:05 -0400 Subject: [PATCH 09/11] Update .golangci.yml --- .golangci.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.golangci.yml b/.golangci.yml index 7bc0320e1065a..677df609421c2 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -139,3 +139,15 @@ issues: linters: - misspell text: '`Unknwon` is a misspelling of `Unknown`' + - path: modules/ssh/ssh.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: routers/install.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: routers/api/v1/convert/convert.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' From d79b42b05568b6c524a94e12ca1e8646415b3201 Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:51:37 -0400 Subject: [PATCH 10/11] Update .golangci.yml --- .golangci.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.golangci.yml b/.golangci.yml index 677df609421c2..66ed4e24d13ca 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -151,3 +151,15 @@ issues: linters: - misspell text: '`Unknwon` is a misspelling of `Unknown`' + - path: routers/api/v1/utils/hook.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: routers/api/v1/user/user.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' + - path: routers/org/members.go + linters: + - misspell + text: '`Unknwon` is a misspelling of `Unknown`' From 387a8bad67bdbd970bf0961474c2b292871286a3 Mon Sep 17 00:00:00 2001 From: techknowlogick Date: Tue, 13 Aug 2019 22:54:37 -0400 Subject: [PATCH 11/11] Update .golangci.yml --- .golangci.yml | 67 +-------------------------------------------------- 1 file changed, 1 insertion(+), 66 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 66ed4e24d13ca..bee342dd75a77 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -95,71 +95,6 @@ issues: linters: - misspell text: '`Destory` is a misspelling of `Destroy`' - - path: modules/setting/repository.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: modules/setting/setting.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: modules/options/dynamic.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: models/migrations/migrations.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: models/migrations/v13.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: models/migrations/v19.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: models/migrations/v21.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: models/migrations/v22.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: models/migrations/v26.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: models/migrations/v25.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: modules/templates/dynamic.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: modules/ssh/ssh.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: routers/install.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: routers/api/v1/convert/convert.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: routers/api/v1/utils/hook.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: routers/api/v1/user/user.go - linters: - - misspell - text: '`Unknwon` is a misspelling of `Unknown`' - - path: routers/org/members.go - linters: + - linters: - misspell text: '`Unknwon` is a misspelling of `Unknown`'