'127.0.0.1:' on tag 'tcp4_addr'

[fx-slayer]

• [Y] I have looked at the documentation here first?

• [Y] I have looked at the examples provided that may showcase my question here?

Package version eg. v9, v10:

V10

Issue, Question or Enhancement:

Is '127.0.0.1:' a valid Tcp4 address? Basically I don't see any sense, if there is any RFC section or reasonable explanation ,i'm glad to know.

Code sample, to showcase or reproduce:

func TestTCP_ADDR(t *testing.T) {
	e := validator.New().Var("127.0.0.1:", "tcp4_addr")
	if e == nil {
		t.Fatal(e)
	}
}

=== RUN   TestTCP_ADDR
    common_test.go:119: <nil>
--- FAIL: TestTCP_ADDR (0.00s)
FAIL
exit status 1

[zemzale]

@7a6bb3ef3 Hi.

I actually can't find any specification about this, but the Go net library is used here for that, and it parses the address and leaves the port at 0. I don't know if that is correct or not by spec or just a mistake on the Go libraries part.

A similar code on rust fails because that probably is not a valid address.

I will see what can be done about this.

[fx-slayer]

I have opened an issues in golang/go, they mentioned #13610 , actually I'm confused about this problem.

what ever ,#13610 may help you.

[zemzale]

As far as I understand it's basically a Go stdlib thing, where if the port is left empty it assumes port 0.

It would still work with net code in your app, but I can see how from a validation standpoint that is not factually correct. I think in that case we should add some extra steps to validation where we check if the part after the port is empty.

[salleh]

I have opened an issues in golang/go, they mentioned #13610 , actually I'm confused about this problem.

what ever ,#13610 may help you.

I guess the existing state of the logic for saying "X.X.X.X:" is a valid tcp4_addr is to not opinionated the validation rule as different underlying platforms behave slightly different from each other in dealing with 'blank' port specification. That is what I understand from reading #13610.

Hence yes, as pointed out by @zemzale, perhaps developers are to consciously aware whether their intended code target will honour the rule or not.