Skip to content

Godot version parsing fails for nix package #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RobWalt opened this issue Mar 6, 2023 · 1 comment
Closed

Godot version parsing fails for nix package #148

RobWalt opened this issue Mar 6, 2023 · 1 comment
Labels
status: duplicate This issue or pull request already exists

Comments

@RobWalt
Copy link

RobWalt commented Mar 6, 2023

I'm using godot on NixOS. I have to use the version of godot on the unstable channel of nixpkgs since the version on the stable channel crashes on startup. This is a link to it

https://search.nixos.org/packages?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=godot_4

When I run godot --version I get 4.0.stable.custom_build. This is also fine and everything works well. But when I try to use gdextension-rust, then I can't compile the code because the build fails because of the version parsing. The reason is, that there is no hash after the ...custom_build part of the version. This is a requirement of the regex defined here

https://github.com/godot-rust/gdextension/blob/master/godot-codegen/src/godot_version.rs#L33

I wanted to ask if we can relax the constraints of the checks there a bit and include ... |official|custom_build at the end of the regex. Is the hash needed anywhere in the code?

@Bromeon
Copy link
Member

Bromeon commented Mar 6, 2023

Duplicate of #118. There was some discussion in that thread, including why I think requiring a version is important.

Could you share your thoughts on that there? Then we have everything in a central place 🙂

@Bromeon Bromeon closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
@Bromeon Bromeon added the status: duplicate This issue or pull request already exists label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants