Skip to content

Do not import gdnative types, and use canonical paths in macros #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #767
ghost opened this issue Oct 21, 2020 · 0 comments
Open
Tracked by #767

Do not import gdnative types, and use canonical paths in macros #624

ghost opened this issue Oct 21, 2020 · 0 comments
Labels
bug c: export Component: export (mod export, derive)
Milestone

Comments

@ghost
Copy link

ghost commented Oct 21, 2020

Importing types from the bindings may shadow identically named user types. For example, this won't currently work because the Signal identifier of the user type will be shadowed by gdnative::nativescript::init::Signal:

#[derive(NativeClass)]
struct Signal;
@ghost ghost added bug c: export Component: export (mod export, derive) labels Oct 21, 2020
@ghost ghost changed the title Do not import gdnative types in macros Do not import gdnative types, and use fully qualified paths in macros Oct 21, 2020
@ghost ghost changed the title Do not import gdnative types, and use fully qualified paths in macros Do not import gdnative types, and use canonical paths in macros Oct 21, 2020
@Bromeon Bromeon added this to the v0.10.1 milestone Nov 1, 2021
@Bromeon Bromeon modified the milestones: v0.10.1, v0.10.2 Jul 16, 2022
@Bromeon Bromeon modified the milestones: v0.10.2, v0.12 Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: export Component: export (mod export, derive)
Projects
None yet
Development

No branches or pull requests

1 participant