cmd/release: install Go to appropriate Program Files directory

The previous default installation path, C:\Go, has default permissions
that are too permissive when adding a directory to the OS path. This
change moves the default installation target to "Program Files" or
"Program Files (x86)", which will inherit appropriate permissions, and
is the canonical place to install software on Windows.

Tested signed windows-386 and windows-amd64 artifacts on a 64-bit
Windows device.

Fixes golang/go#42070

Change-Id: I4a4cf744e53bb8f75b53d0f918de1707c4847882
Reviewed-on: https://go-review.googlesource.com/c/build/+/283600
Trust: Alexander Rakoczy <[email protected]>
Run-TryBot: Alexander Rakoczy <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>

Author: toothrot

cmd/release/releaselet.go

@@ -366,10 +366,12 @@ var windowsData = map[string]string{
   <?define ProdId = {FF5B30B2-08C2-11E1-85A2-6ACA4824019B} ?>
   <?define UpgradeCode = {1C3114EA-08C3-11E1-9095-7FCA4824019B} ?>
   <?define SysFolder=SystemFolder ?>
+  <?define ArchProgramFilesFolder="ProgramFilesFolder" ?>
 <?else?>
   <?define ProdId = {716c3eaa-9302-48d2-8e5e-5cfec5da2fab} ?>
   <?define UpgradeCode = {22ea7650-4ac6-4001-bf29-f4b8775db1c0} ?>
   <?define SysFolder=System64Folder ?>
+  <?define ArchProgramFilesFolder="ProgramFiles64Folder" ?>
 <?endif?>
 
 <Product
@@ -406,7 +408,6 @@ var windowsData = map[string]string{
     ((VersionNT > 601) OR (VersionNT = 601 AND ServicePackLevel >= 1))
 </Condition>
 <MajorUpgrade AllowDowngrades="yes" />
-<SetDirectory Id="INSTALLDIRROOT" Value="[%SYSTEMDRIVE]"/>
 
 <CustomAction
     Id="SetApplicationRootDirectory"
@@ -415,7 +416,7 @@ var windowsData = map[string]string{
 
 <!-- Define the directory structure and environment variables -->
 <Directory Id="TARGETDIR" Name="SourceDir">
-  <Directory Id="INSTALLDIRROOT">
+  <Directory Id="$(var.ArchProgramFilesFolder)">
     <Directory Id="INSTALLDIR" Name="Go"/>
   </Directory>
   <Directory Id="ProgramMenuFolder">