Skip to content

Commit 106fb71

Browse files
dmitshurgopherbot
authored andcommitted
dashboard: remove known issue for openbsd-ppc64-n2vi
The port is added and the builder is passing. Also add misc-compile coverage for presubmit. Fixes golang/go#56001. Change-Id: Ifbad54d9d7ec620f224d85a6f5c85ed73772fe42 Reviewed-on: https://go-review.googlesource.com/c/build/+/548218 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
1 parent f09ccbd commit 106fb71

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

dashboard/builders.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1675,6 +1675,7 @@ func init() {
16751675
addMiscCompile("freebsd", "386")
16761676
addMiscCompile("freebsd", "arm")
16771677
addMiscCompile("freebsd", "arm64")
1678+
addMiscCompile("freebsd", "riscv64")
16781679
addMiscCompile("netbsd", "386")
16791680
addMiscCompile("netbsd", "amd64")
16801681
addMiscCompile("netbsd", "arm")
@@ -1683,6 +1684,7 @@ func init() {
16831684
// openbsd-mips64 go.dev/issue/58110
16841685
addMiscCompile("openbsd", "arm")
16851686
addMiscCompile("openbsd", "arm64")
1687+
addMiscCompileGo1(22, "openbsd", "ppc64", "-go1.22")
16861688
addMiscCompile("plan9", "386")
16871689
addMiscCompile("plan9", "amd64")
16881690
addMiscCompile("plan9", "arm")
@@ -1694,7 +1696,6 @@ func init() {
16941696
addMiscCompile("linux", "s390x")
16951697
addMiscCompile("linux", "arm")
16961698
addMiscCompileGo1(0, "linux", "arm", "-arm5", "GOARM=5")
1697-
addMiscCompileGo1(20, "freebsd", "riscv64", "-go1.20")
16981699

16991700
// TODO: Issue 25963, get the misc-compile trybots for Android/iOS.
17001701
// Then consider subrepos too, so "mobile" can at least be included
@@ -2126,7 +2127,6 @@ func init() {
21262127
addBuilder(BuildConfig{
21272128
Name: "openbsd-ppc64-n2vi",
21282129
HostType: "host-openbsd-ppc64-n2vi",
2129-
KnownIssues: []int{56001},
21302130
SkipSnapshot: true,
21312131
FlakyNet: true,
21322132
buildsRepo: func(repo, branch, goBranch string) bool {

dashboard/builders_test.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,15 @@ func TestTrybots(t *testing.T) {
117117
"misc-compile-freebsd-386",
118118
"misc-compile-freebsd-arm",
119119
"misc-compile-freebsd-arm64",
120+
"misc-compile-freebsd-riscv64",
120121
"misc-compile-netbsd-386",
121122
"misc-compile-netbsd-amd64",
122123
"misc-compile-netbsd-arm",
123124
"misc-compile-netbsd-arm64",
124125
"misc-compile-openbsd-386",
125126
"misc-compile-openbsd-arm",
126127
"misc-compile-openbsd-arm64",
128+
"misc-compile-openbsd-ppc64-go1.22",
127129
"misc-compile-plan9-386",
128130
"misc-compile-plan9-amd64",
129131
"misc-compile-plan9-arm",
@@ -135,7 +137,6 @@ func TestTrybots(t *testing.T) {
135137
"misc-compile-linux-s390x",
136138
"misc-compile-linux-arm",
137139
"misc-compile-linux-arm-arm5",
138-
"misc-compile-freebsd-riscv64-go1.20",
139140
},
140141
},
141142
{
@@ -168,6 +169,7 @@ func TestTrybots(t *testing.T) {
168169
"misc-compile-freebsd-386",
169170
"misc-compile-freebsd-arm",
170171
"misc-compile-freebsd-arm64",
172+
"misc-compile-freebsd-riscv64",
171173
"misc-compile-netbsd-386",
172174
"misc-compile-netbsd-amd64",
173175
"misc-compile-netbsd-arm",
@@ -186,7 +188,6 @@ func TestTrybots(t *testing.T) {
186188
"misc-compile-linux-s390x",
187189
"misc-compile-linux-arm",
188190
"misc-compile-linux-arm-arm5",
189-
"misc-compile-freebsd-riscv64-go1.20",
190191

191192
// Include longtest builders on Go repo release branches. See issue 37827.
192193
"linux-386-longtest",
@@ -227,6 +228,7 @@ func TestTrybots(t *testing.T) {
227228
"misc-compile-freebsd-386",
228229
"misc-compile-freebsd-arm",
229230
"misc-compile-freebsd-arm64",
231+
"misc-compile-freebsd-riscv64",
230232
"misc-compile-netbsd-386",
231233
"misc-compile-netbsd-amd64",
232234
"misc-compile-netbsd-arm",
@@ -245,7 +247,6 @@ func TestTrybots(t *testing.T) {
245247
"misc-compile-linux-s390x",
246248
"misc-compile-linux-arm",
247249
"misc-compile-linux-arm-arm5",
248-
"misc-compile-freebsd-riscv64-go1.20",
249250

250251
// Include longtest builders on Go repo release branches. See issue 37827.
251252
"linux-386-longtest",
@@ -296,13 +297,15 @@ func TestTrybots(t *testing.T) {
296297
"misc-compile-freebsd-386",
297298
"misc-compile-freebsd-arm",
298299
"misc-compile-freebsd-arm64",
300+
"misc-compile-freebsd-riscv64",
299301
"misc-compile-netbsd-386",
300302
"misc-compile-netbsd-amd64",
301303
"misc-compile-netbsd-arm",
302304
"misc-compile-netbsd-arm64",
303305
"misc-compile-openbsd-386",
304306
"misc-compile-openbsd-arm",
305307
"misc-compile-openbsd-arm64",
308+
"misc-compile-openbsd-ppc64-go1.22",
306309
"misc-compile-plan9-386",
307310
"misc-compile-plan9-amd64",
308311
"misc-compile-plan9-arm",
@@ -314,7 +317,6 @@ func TestTrybots(t *testing.T) {
314317
"misc-compile-linux-s390x",
315318
"misc-compile-linux-arm",
316319
"misc-compile-linux-arm-arm5",
317-
"misc-compile-freebsd-riscv64-go1.20",
318320
},
319321
},
320322
{
@@ -1005,7 +1007,6 @@ func TestTryBotsCompileAllPorts(t *testing.T) {
10051007
// when the work of adding a new port is actively underway.
10061008
knownMissing := map[string]bool{
10071009
"openbsd-mips64": true, // go.dev/issue/58110
1008-
"openbsd-ppc64": true, // go.dev/issue/56001
10091010
}
10101011

10111012
var done = make(map[string]bool)

0 commit comments

Comments
 (0)