Skip to content

Commit 1d025ee

Browse files
prattmicgopherbot
authored andcommitted
all: upgrade to golang.org/x/perf@3fd27c2392831a268043c8e09d4599e7f1c441d3
This fixes AllComparisonSeries to return errors rather than panicking. For golang/go#53538. Change-Id: I872a1a77c8aedc3827dec650c21afa7c68b540af Reviewed-on: https://go-review.googlesource.com/c/build/+/459195 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: David Chase <[email protected]> Auto-Submit: Michael Pratt <[email protected]> Run-TryBot: Michael Pratt <[email protected]>
1 parent cabcec9 commit 1d025ee

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ require (
5252
golang.org/x/mod v0.6.0
5353
golang.org/x/net v0.1.0
5454
golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8
55-
golang.org/x/perf v0.0.0-20220913151710-7c6e287988f3
55+
golang.org/x/perf v0.0.0-20221222170352-3fd27c239283
5656
golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4
5757
golang.org/x/sys v0.1.0
5858
golang.org/x/term v0.1.0

go.sum

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,6 +1030,8 @@ golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8 h1:RerP+noqYHUQ8CMRcPlC2n
10301030
golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8/go.mod h1:KelEdhl1UZF7XfJ4dDtk6s++YSgaE7mD/BuKKDLBl4A=
10311031
golang.org/x/perf v0.0.0-20220913151710-7c6e287988f3 h1:ChUtQhjSq/uYjerTlcpLrOkD2bGMcrRuDutZVPHo3WE=
10321032
golang.org/x/perf v0.0.0-20220913151710-7c6e287988f3/go.mod h1:UBKtEnL8aqnd+0JHqZ+2qoMDwtuy6cYhhKNoHLBiTQc=
1033+
golang.org/x/perf v0.0.0-20221222170352-3fd27c239283 h1:MTXrvYGLsaCdRXRtex0LY6RotT5TXmQ3Ru+5d1CnPIM=
1034+
golang.org/x/perf v0.0.0-20221222170352-3fd27c239283/go.mod h1:UBKtEnL8aqnd+0JHqZ+2qoMDwtuy6cYhhKNoHLBiTQc=
10331035
golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
10341036
golang.org/x/sync v0.0.0-20181108010431-42b317875d0f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
10351037
golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=

perf/app/influx.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,10 @@ func (a *App) pushRunToInflux(ctx context.Context, ifxc influxdb2.Client, u perf
268268

269269
// Run the comparison. We don't have any existing results so our
270270
// duplicate policy doesn't matter here. Just pick replacement.
271-
comparisons := builder.AllComparisonSeries(nil, benchseries.DUPE_REPLACE)
271+
comparisons, err := builder.AllComparisonSeries(nil, benchseries.DUPE_REPLACE)
272+
if err != nil {
273+
return fmt.Errorf("failed to creation comparison series: %w", err)
274+
}
272275

273276
const (
274277
confidence = 0.95

0 commit comments

Comments
 (0)